Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Callum style layout improvements and my layout changes #16174

Merged
merged 81 commits into from
Oct 25, 2022
Merged

Conversation

daliusd
Copy link
Contributor

@daliusd daliusd commented Feb 2, 2022

Description

This changeset mainly includes updated Callum style layout implementation:

  • Simplified configuration for Callum style layout
  • Added documentation how to use it if you want to use it with your keyboard
  • Added unit-tests in case you want to change something

As well I have change my layout. There are minor things that some people might find interesting.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@daliusd daliusd restored the flow branch September 12, 2022 19:17
@daliusd daliusd reopened this Oct 3, 2022
@daliusd
Copy link
Contributor Author

daliusd commented Oct 3, 2022

@drashna please review again :-)

@drashna drashna merged commit f100de8 into qmk:master Oct 25, 2022
@daliusd
Copy link
Contributor Author

daliusd commented Oct 25, 2022

@drashna thanks

hirakiuc pushed a commit to hirakiuc/qmk_firmware that referenced this pull request Oct 29, 2022
aivalja pushed a commit to aivalja/qmk_firmware that referenced this pull request Nov 7, 2022
thystips pushed a commit to thystips/qmk_firmware that referenced this pull request Nov 24, 2022
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
ChrisChrisLoLo pushed a commit to ChrisChrisLoLo/qmk_firmware that referenced this pull request Sep 2, 2023
@Abraxas-Knister
Copy link

this was merged, why can't I find it in the current master? Is is still expected to work?

@fauxpark
Copy link
Member

fauxpark commented May 5, 2024

#22724

@qmk qmk locked as resolved and limited conversation to collaborators May 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants