[Core] Add compile/make macro to core #15959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zvecr
reviewed
Jan 21, 2022
fauxpark
reviewed
Jan 21, 2022
drashna
force-pushed
the
core/make
branch
2 times, most recently
from
ba50fc1 to
9358177
Compare
drashna
force-pushed
the
core/make
branch
2 times, most recently
from
ec17fed to
485ad73
Compare
drashna
changed the title
precondition
reviewed
Feb 7, 2022
zvecr
requested changes
Feb 11, 2022
|
Tinkering with this, even just a send_string adds about 500 bytes to the firmware. Which is a surprisingly large amount (even when it's a set string). Making it opt-in is probably best. |
drashna
force-pushed
the
core/make
branch
2 times, most recently
from
e01d018 to
8337569
Compare
fix linting fix testing error work around test idiocyncracies fix more lint something something stupid tests add doc
Co-authored-by: precondition <[email protected]>
zvecr
reviewed
Mar 16, 2022
Co-authored-by: Joel Challis <[email protected]>
zvecr
approved these changes
Mar 17, 2022
0xcharly
pushed a commit
to Bastardkb/bastardkb-qmk
that referenced
this pull request
Jul 4, 2022
* [Core] Add KC_MAKE keycode to core fix linting fix testing error work around test idiocyncracies fix more lint something something stupid tests add doc * updates based on feedback * Add bad names * Fixup docs * semantics but cleaner Co-authored-by: precondition <[email protected]> * Hide oneshot checks behind preprocessors * Move no-compile option around * Fix formatting * make shift optional * Make opt in * fix formatting * update send string function name Co-authored-by: Joel Challis <[email protected]> Co-authored-by: precondition <[email protected]> Co-authored-by: Joel Challis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This outputs
qmk compile -kb {keyboard} -km {keymap}on tap, orqmk flashif shift is held with it.Types of Changes
Checklist