Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "core: make the full 4096 bytes of EEPROM work on Teensy 3.6 (#12947) #15695

Merged
merged 1 commit into from
Jan 9, 2022
Merged

Revert "core: make the full 4096 bytes of EEPROM work on Teensy 3.6 (#12947) #15695

merged 1 commit into from
Jan 9, 2022

Conversation

stapelberg
Copy link
Contributor

This reverts commit 7f8faa4.

related to #15521

Description

Multiple people have reported issues with the Teensy 3.6 after our EEPROM changes made it in the most recent breakpoint, see #15521

For now, we should revert the changes.

This PR is against the develop branch — can you cherry-pick the revert into master afterwards, or what’s the process? :)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Jan 1, 2022
@stapelberg stapelberg mentioned this pull request Jan 1, 2022
Closed
@drashna drashna requested review from tzarc, zvecr and a team January 1, 2022 15:53
@tzarc tzarc added the bug label Jan 7, 2022
@tzarc
Copy link
Member

tzarc commented Jan 7, 2022 •
edited
Loading

This PR is against the develop branch — can you cherry-pick the revert into master afterwards, or what’s the process? :)

Bugfixes can go to master.

@stapelberg stapelberg changed the base branch from develop to master January 7, 2022 09:21
@stapelberg
Copy link
Contributor Author

Now updated to target master. Please take a look :)

@tzarc tzarc merged commit 7c186eb into qmk:master Jan 9, 2022
@stapelberg stapelberg deleted the revert-eeprom branch January 9, 2022 21:28
ryphon pushed a commit to ryphon/qmk_firmware that referenced this pull request Jan 12, 2022
@stapelberg @ryphon
Revert "core: make the full 4096 bytes of EEPROM work on Teensy 3.6 (q…
2e42439 
…mk#12947)" (qmk#15695)

This reverts commit 7f8faa4.

related to qmk#15521
magdalipka pushed a commit to magdalipka/qmk_firmware that referenced this pull request Jul 20, 2023
@stapelberg
Revert "core: make the full 4096 bytes of EEPROM work on Teensy 3.6 (q…
3242947 
…mk#12947)" (qmk#15695)

This reverts commit 7f8faa4.

related to qmk#15521
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

@drashna drashna drashna approved these changes

@zvecr zvecr Awaiting requested review from zvecr

Assignees
No one assigned
Labels
bug core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stapelberg @tzarc @drashna