Save a single byte of memory for joystick buttons #15555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
broekema
changed the title
drashna
approved these changes
Dec 22, 2021
fauxpark
approved these changes
Dec 22, 2021
zvecr
requested changes
Dec 23, 2021
indent Co-authored-by: Joel Challis <[email protected]>
ryphon
pushed a commit
to ryphon/qmk_firmware
that referenced
this pull request
Jan 12, 2022
Co-authored-by: Joel Challis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While tracking down a bug in the joystick QMK implementation I noticed that the struct containing buttons allocates a byte more than needed.
Of course no big issue, but since I found it I better share it.
Description
Allocate precisely enough memory (in bytes) to contain the number of buttons, instead of one byte too much.
Types of Changes
Issues Fixed or Closed by This PR
Checklist