Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Add configuration of PMW3360 lift off distance #15424

Merged
merged 4 commits into from
Dec 9, 2021

Conversation

Xelus22
Copy link
Contributor

@Xelus22 Xelus22 commented Dec 7, 2021

Description

Adds the ability to set the lift off distance between the sensor and the surface.
Currently the default is set to 0x02 (please refer to the datasheet).
Using #define PMW3360_LIFTOFF_DISTANCE xxx will allow the user to set the wanted distance.

e.g. #define PMW3360_LIFTOFF_DISTANCE 0x27

Tested and working

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • Add lift off distance change

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@Xelus22 Xelus22 changed the title [Core] Add PMW3360 lift off distance change [Core] Add configuration of PMW3360 lift off distance Dec 7, 2021
@Xelus22 Xelus22 requested review from zvecr and drashna December 8, 2021 06:11
drivers/sensors/pmw3360.c Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team December 9, 2021 06:25
@drashna drashna merged commit b09c44c into qmk:master Dec 9, 2021
@Xelus22 Xelus22 deleted the pwm3360_liftoff branch March 10, 2023 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants