Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keyhive sofle rgb: fix configuration. #15319

Closed
wants to merge 1 commit into from

Conversation

winder
Copy link

@winder winder commented Nov 27, 2021

Description

  • Change PRODUCT_ID and DEVICE_VER to match sofle/rev1.
  • Update readme.md to use qmk and via keymap.

Note: With this change, the keyhive PRODUCT_ID and DEVICE_VER match that of sofle/rev1. Strictly speaking, this is incorrect for a couple reasons (it's a different product, and the v1/v2 keyboards are slightly different). It is, however, what the keyhive fork does. It also corrects the via issues mentioned in the readme.

I'll probably look into updating via as well. If I do that, I'll create a follow-up PR here. Until then, I believe these changes are an improvement to the current sofle/keyhive support.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

* Change PRODUCT_ID and DEVICE_VER to match sofle/rev1.
* Update readme.md to use qmk and via keymap.
@fauxpark
Copy link
Member

If they are different keyboards then for VIA purposes the product IDs must be different.

@winder
Copy link
Author

winder commented Nov 27, 2021

If they are different keyboards then for VIA purposes the product IDs must be different.

In this PR I'm updating the configuration to match the keyhive fork:
keyhive@a388b3e#diff-9134896d5f7bbd3575e3197e4752653dff4a420459009bca10ad94f09e909d57R3

I'm still experimenting with this, but it seems that there are some incompatibilities when forcing keyhive v2.1 to use the open source sofle v1 configuration:
the-via/keyboards#337 (comment)

Not sure the best way to proceed. From my perspective this works as well as the keyhive fork, but maybe that isn't good enough?

@winder
Copy link
Author

winder commented Nov 28, 2021

I figured out why things are a little messed up in the sofle/keyhive configuration. Half of the code has been taken from https://github.com/solartempest/sofle and half from https://github.com/keyhive/qmk_firmware

The keyhive/qmk_firmware changes work better out of the box, but are less advanced than the solartempest/sofle fork.

Closing this PR for now, I'll re-open with later once I've cleaned things up.

@winder winder closed this Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants