keyhive sofle rgb: fix configuration. #15319
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Note: With this change, the keyhive PRODUCT_ID and DEVICE_VER match that of sofle/rev1. Strictly speaking, this is incorrect for a couple reasons (it's a different product, and the v1/v2 keyboards are slightly different). It is, however, what the keyhive fork does. It also corrects the via issues mentioned in the readme.
I'll probably look into updating via as well. If I do that, I'll create a follow-up PR here. Until then, I believe these changes are an improvement to the current sofle/keyhive support.
Types of Changes
Checklist