-
-
Notifications
You must be signed in to change notification settings - Fork 40.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update fix for MW65_rgb and added personal keymap #15279
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
C/H Source files all need to have appropriate license headers, as per the PR Checklist.
Might be wise giving the whole checklist a look through to see if there are any others that need fixing up, too.
5b9fc82
to
843abf4
Compare
Thanks for suggest changes, done for fixed them. Please, take a look if anything problem |
keyboards/mwstudio/mw65_rgb/rules.mk
Outdated
ENCODER_ENABLE = yes | ||
|
||
LAYOUTS = 65_ansi_blocker |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't actually work – the 65_ansi_blocker
community layout has 67 keys, but the layout macro has 69, due to the assignments for the rotation of the rotary encoder.
I'd prefer the layout macro name remain as LAYOUT
as well.
LAYOUTS = 65_ansi_blocker |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Thanks! |
Description
Giving correct layout name to 65_ansi_blockerTypes of Changes
Checklist