Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fix for MW65_rgb and added personal keymap #15279

Merged
merged 5 commits into from
Feb 21, 2022

Conversation

HorrorTroll
Copy link
Contributor

@HorrorTroll HorrorTroll commented Nov 23, 2021

Description

  • Update fix for using 6 rows instead 5 rows, pin B0 was unused
  • No need RGBLIGHT, since this one wasn't used
  • Correct LED flag for underglow, key light, modifier, indicator
  • Re-calculation LED position
  • Giving correct layout name to 65_ansi_blocker
  • Added 2 personal keymap for me and my friend (he doesn't know coding, sorry)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Nov 23, 2021
Copy link
Member

@tzarc tzarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C/H Source files all need to have appropriate license headers, as per the PR Checklist.

Might be wise giving the whole checklist a look through to see if there are any others that need fixing up, too.

@HorrorTroll
Copy link
Contributor Author

HorrorTroll commented Dec 27, 2021

Thanks for suggest changes, done for fixed them. Please, take a look if anything problem

ENCODER_ENABLE = yes

LAYOUTS = 65_ansi_blocker
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't actually work – the 65_ansi_blocker community layout has 67 keys, but the layout macro has 69, due to the assignments for the rotation of the rotary encoder.

I'd prefer the layout macro name remain as LAYOUT as well.

Suggested change
LAYOUTS = 65_ansi_blocker

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thanks

Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@noroadsleft noroadsleft merged commit 3bc8afb into qmk:master Feb 21, 2022
@noroadsleft
Copy link
Member

Thanks!

@HorrorTroll HorrorTroll deleted the mw65_fix branch February 21, 2022 04:12
@waffle87 waffle87 mentioned this pull request Feb 21, 2022
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants