Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix encoder bug from #12090 #15239

Merged
merged 1 commit into from
Nov 20, 2021
Merged

Fix encoder bug from #12090 #15239

merged 1 commit into from
Nov 20, 2021

Conversation

BalzGuenat
Copy link
Contributor

@BalzGuenat BalzGuenat commented Nov 20, 2021 •
edited by drashna
Loading

Description

Should fixe the bugs introduced with #12090.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@BalzGuenat BalzGuenat changed the base branch from master to develop November 20, 2021 19:51
@github-actions github-actions bot added CI cli qmk cli command core documentation keyboard keymap translation via Adds via keymap and/or updates keyboard for via support labels Nov 20, 2021
@drashna drashna mentioned this pull request Nov 20, 2021
Closed
@drashna drashna requested a review from a team November 20, 2021 19:54
@zvecr zvecr merged commit 06f18e2 into qmk:develop Nov 20, 2021
drashna added a commit to drashna/qmk_firmware that referenced this pull request Nov 27, 2021
@drashna
Revert "fix broken macro in transport.h (qmk#15239)"
67778dc 
This reverts commit 06f18e2.
tzarc pushed a commit that referenced this pull request Nov 27, 2021
@drashna
[Bug] Revert Assymmetrical Split Encoder support (#12090) (#15311)
4d0dd1e 
* Revert "fix broken macro in transport.h (#15239)"

This reverts commit 06f18e2.

* Revert "Rework encoders to enable asymmetric split keyboards (#12090)"

This reverts commit 32215d5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
CI cli qmk cli command core documentation keyboard keymap translation via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BalzGuenat @drashna @zvecr