Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matrix/abelx - Update ChibiOS conf files #15130

Merged
merged 2 commits into from
Nov 12, 2021

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Nov 12, 2021

Description

Further updates to 15129, due to the dependency bump.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr requested review from tzarc and a team November 12, 2021 01:48
@tzarc
Copy link
Member

tzarc commented Nov 12, 2021

can we use the conf migrator stuff for all the configs instead?

@zvecr
Copy link
Member Author

zvecr commented Nov 12, 2021

We could, except that also requires the change to inherit from the core board files to migrate the mcuconf.h.

@drashna drashna requested a review from a team November 12, 2021 16:33
@tzarc
Copy link
Member

tzarc commented Nov 12, 2021

We could, except that also requires the change to inherit from the core board files to migrate the mcuconf.h.

Ugh, I didn't see it was another matrix board. Sigh.

@tzarc tzarc merged commit bd35978 into qmk:develop Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants