Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Keyboard] Fix compilation issues for yanghu Unicorne #15068

Merged
merged 1 commit into from
Nov 5, 2021

Conversation

drashna
Copy link
Member

@drashna drashna commented Nov 5, 2021

Description

This is broken on master too, not sure if worth fixing there, since part of the breakage is i2c_init related.

  • Fixes issues with i2c compiling, due to changes with i2c setup.
  • Fixes oled callbacks

Types of Changes

  • Bugfix
  • Keyboard (addition or update)

Issues Fixed or Closed by This PR

  • Tzarc CI

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • [ x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team November 5, 2021 16:46
@drashna drashna merged commit 69ef8d6 into qmk:develop Nov 5, 2021
@drashna drashna deleted the keyboard/unicorne_fixes branch November 5, 2021 18:25
ptrxyz pushed a commit to ptrxyz/qmk_firmware that referenced this pull request Apr 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants