Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overnumpad controller: Add support for turning off solenoid enable in low power. #15021

Conversation

purdeaandrei
Copy link
Contributor

Description

This PR enables the recently merged feature from #12692 on the 5 overnumpad controller keyboards.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).
    (testing was done months ago, did not retest since recent unrelated qmk developments, however I expect this to keep working)

@tzarc tzarc requested a review from a team November 2, 2021 06:05
@tzarc tzarc merged commit 2326c8f into qmk:develop Nov 2, 2021
ptrxyz pushed a commit to ptrxyz/qmk_firmware that referenced this pull request Apr 9, 2022
@purdeaandrei purdeaandrei deleted the f_overnumpad_controller_keyboards_add_support_for_haptic_off_in_low_power branch September 10, 2022 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants