Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard] Fix missing return for oled task on Lefty #15010

Merged
merged 1 commit into from
Nov 2, 2021
Merged

[Keyboard] Fix missing return for oled task on Lefty #15010

merged 1 commit into from
Nov 2, 2021

Conversation

drashna
Copy link
Member

@drashna drashna commented Nov 2, 2021

Description

Somehow, I missed this?

oled_task_kb doesn't return a value.

Types of Changes

  • Bugfix
  • Keyboard (addition or update)

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna added the bug label Nov 2, 2021
@drashna drashna requested a review from a team November 2, 2021 01:50
@tzarc tzarc merged commit 4bc1b12 into qmk:develop Nov 2, 2021
@drashna drashna deleted the keyboard/fix_lefty_oled branch November 2, 2021 02:03
ptrxyz pushed a commit to ptrxyz/qmk_firmware that referenced this pull request Apr 9, 2022
@drashna @ptrxyz
[Keyboard] Fix missing return for oled task on Lefty (qmk#15010)
f3ee196
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
bug keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drashna @tzarc