Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove BOOTMAGIC_ENABLE = lite option #15002

Merged
merged 13 commits into from
Nov 4, 2021

Conversation

noroadsleft
Copy link
Member

Description

Final stage of the BOOTMAGIC_ENABLE rework.

Changes all instances of BOOTMAGIC_ENABLE = lite to BOOTMAGIC_ENABLE = yes.

Types of Changes

  • Core
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
    • The Japanese docs will need an update here. I looked them over and it seems the English docs have diverged as far as Bootmagic functionality is concerned, but some of the updates required look to be out of scope for this PR.
  • I have read the CONTRIBUTING document.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Edits keyboard-level instances of `BOOTMAGIC_ENABLE = lite` to `BOOTMAGIC_ENABLE = yes`.
Edits keyboard-level BOOTMAGIC_ENABLE inline comments to "Enable Bootmagic Lite".
Edits keymap-level instances of `BOOTMAGIC_ENABLE = lite` to `BOOTMAGIC_ENABLE = yes`.
Edits/adds keymap-level BOOTMAGIC_ENABLE inline comments to read "Enable Bootmagic Lite".
Edits instances of `BOOTMAGIC_ENABLE = lite` to `BOOTMAGIC_ENABLE = yes`.

Edits/adds keymap-level BOOTMAGIC_ENABLE inline comments to read "Enable Bootmagic Lite".
@noroadsleft noroadsleft requested a review from a team November 1, 2021 16:09
@github-actions github-actions bot added cli qmk cli command core documentation keyboard keymap python translation via Adds via keymap and/or updates keyboard for via support labels Nov 1, 2021
Copy link
Member

@tzarc tzarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Burn it with fire.

@noroadsleft
Copy link
Member Author

@mtei,

I would appreciate guidance on the changes I made to the Japanese docs in a6de112.


@qmk/python,

Similarly, I'm not sure if the changes in 8d16db1 and ed4afda encompass everything that's needed for the data-driven side of this equation.

docs/ja/config_options.md Outdated Show resolved Hide resolved
@tzarc tzarc merged commit 84ea77e into qmk:develop Nov 4, 2021
@noroadsleft noroadsleft deleted the rm/bootmagic-full_q4a branch November 4, 2021 21:33
ptrxyz pushed a commit to ptrxyz/qmk_firmware that referenced this pull request Apr 9, 2022
* remove BOOTMAGIC_ENABLE=lite setting

* change keyboard BOOTMAGIC_ENABLE rules

Edits keyboard-level instances of `BOOTMAGIC_ENABLE = lite` to `BOOTMAGIC_ENABLE = yes`.

* change keyboard BOOTMAGIC_ENABLE inline comments

Edits keyboard-level BOOTMAGIC_ENABLE inline comments to "Enable Bootmagic Lite".

* change keymap BOOTMAGIC_ENABLE rules

Edits keymap-level instances of `BOOTMAGIC_ENABLE = lite` to `BOOTMAGIC_ENABLE = yes`.

* change keymap BOOTMAGIC_ENABLE inline comments

Edits/adds keymap-level BOOTMAGIC_ENABLE inline comments to read "Enable Bootmagic Lite".

* change layout/user BOOTMAGIC_ENABLE rules/comments

Edits instances of `BOOTMAGIC_ENABLE = lite` to `BOOTMAGIC_ENABLE = yes`.

Edits/adds keymap-level BOOTMAGIC_ENABLE inline comments to read "Enable Bootmagic Lite".

* update non-rules.mk BOOTMAGIC_ENABLE references in keyboards/

* remove docs references to Full Bootmagic

* convert data-driven Bootmagic Lite instances

* remove Bootmagic Lite bodge from data-driven generation

* Merge remote-tracking branch 'upstream/develop' into rm/bootmagic-full_q4a

* update docs/ja/config_options.md per mtei

* update docs/faq_misc.md per mtei

Remove remaining Full Bootmagic reference.
mtei added a commit to mtei/qmk_firmware that referenced this pull request Apr 24, 2022
h-mikisato added a commit to h-mikisato/TONE_NOTE_Rev2 that referenced this pull request May 14, 2022
QMKが2021/11/27の更新で、BOOTMAGIC_ENABLEにyesもしくはno以外の引数を指定するとコンパイルエラーとなるようになったため。
yesが旧来のliteの意味となった。
cf. qmk/qmk_firmware#15002
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli qmk cli command core documentation keyboard keymap python translation via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants