Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard] Fix Compile issues for lefty #14982

Merged
merged 1 commit into from
Oct 29, 2021
Merged

[Keyboard] Fix Compile issues for lefty #14982

merged 1 commit into from
Oct 29, 2021

Conversation

drashna
Copy link
Member

@drashna drashna commented Oct 29, 2021

Description

Fixes compilation for rev1/rev2 folders by adding an empty rules.mk, and fixes keymaps.

Types of Changes

  • Bugfix
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)

Issues Fixed or Closed by This PR

  • Compilation issues

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team October 29, 2021 22:52
@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Oct 29, 2021
@drashna drashna merged commit 70e396e into qmk:develop Oct 29, 2021
@drashna drashna deleted the keyboard/fix_lefty branch October 29, 2021 23:25
ptrxyz pushed a commit to ptrxyz/qmk_firmware that referenced this pull request Apr 9, 2022
@drashna @ptrxyz
[Keyboard] Fix Compile issues for lefty (qmk#14982)
7698576
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drashna @zvecr