Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Enable emulated eeprom when using F401xE. #14752

Merged
merged 1 commit into from
Oct 8, 2021

Conversation

daskygit
Copy link
Member

@daskygit daskygit commented Oct 8, 2021

Not really much to change, I added the defined checks for STM32F401xE so it should work correctly if using the NUCLEO F401RE as a base.

I tested using the existing blackpill f401 platform by undefining STM32F401xC, defining STM32F401xE in my board.h and setting MCU_LDSCRIPT = STM32F401xE in my rules.mk.

ldflags.txt in .build shows the correct ldscript being used --script=./platforms/chibios/boards/common/ld/STM32F401xE.ld

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Oct 8, 2021
@zvecr zvecr requested a review from a team October 8, 2021 14:02
@zvecr zvecr merged commit 7b753f2 into qmk:develop Oct 8, 2021
@daskygit daskygit deleted the pr/f401xe_eeprom branch November 10, 2021 17:13
ptrxyz pushed a commit to ptrxyz/qmk_firmware that referenced this pull request Apr 9, 2022
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants