Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align PS/2 GPIO defines #14745

Merged
merged 6 commits into from
Oct 20, 2021
Merged

Align PS/2 GPIO defines #14745

merged 6 commits into from
Oct 20, 2021
+94 −192

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Oct 7, 2021 •
edited
Loading

Description

Still a lot of USART and Interrupt to clean up, but that will be another pass. As will be relocation of the files to somewhere like /drivers/ps2/.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr marked this pull request as ready for review October 7, 2021 22:10
@zvecr zvecr requested a review from a team October 7, 2021 22:10
sigprof
sigprof reviewed Oct 8, 2021
View reviewed changes
tmk_core/protocol/ps2_io.c Outdated Show resolved Hide resolved
@zvecr zvecr changed the title Align PS/2 GPIO Align PS/2 GPIO defines Oct 8, 2021
@drashna drashna requested a review from sigprof October 11, 2021 00:55
sigprof
sigprof approved these changes Oct 19, 2021
View reviewed changes
Copy link
Contributor

@sigprof sigprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks equivalent to what was there before… hope that it would actually work the same.

@zvecr zvecr merged commit 84d5198 into qmk:develop Oct 20, 2021
cadusk pushed a commit to cadusk/qmk_firmware that referenced this pull request Oct 21, 2021
Merge remote-tracking branch 'qmk/develop' into develop
2193c67 
* qmk/develop:
  Tidy up LCD_ENABLE/visualizer references (qmk#14855)
  Relocate PS2 code (qmk#14895)
  Rename platform SRC variable (qmk#14894)
  Align PS/2 GPIO defines (qmk#14745)
  Fix type of Tap Dance max index variable (qmk#14887)
  Make the MAGIC_TOGGLE_GUI keycode work (qmk#14886)
ptrxyz pushed a commit to ptrxyz/qmk_firmware that referenced this pull request Apr 9, 2022
@zvecr @ptrxyz
Align PS/2 GPIO defines (qmk#14745)
420dabd 
* Align PS/2 GPIO

* Align PS/2 GPIO

* refactor more keyboards

* Remove more defines

* Put back avr/chibios split

* format
MMcM added a commit to MMcM/qmk_firmware that referenced this pull request Oct 22, 2022
@MMcM
Fix PS2 pin definitions for qmk#14745
4cc0a26 
Replace serial_mouse removed by qmk#14969
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@zvecr
Align PS/2 GPIO defines (qmk#14745)
07e6e49 
* Align PS/2 GPIO

* Align PS/2 GPIO

* refactor more keyboards

* Remove more defines

* Put back avr/chibios split

* format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@sigprof sigprof sigprof approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
core documentation enhancement keyboard keymap translation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zvecr @sigprof @drashna @fauxpark