Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove complex fn_actions macros #14662

Merged
merged 2 commits into from
Oct 31, 2021
Merged

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Oct 1, 2021

Description

These are the last remnants of the deprecated fn_actions system, apart from the LFKeyboards code which I will tackle in a separate PR.

I tried to migrate as much as I could but unfortunately a lot of this stuff was too complex and probably requires conversion to Tap Dance. I didn't want to spend much more time on it, so some parts have had to be deleted without migration.

@uzytkownik
@nrrkeene
@ccojocar
@nathanejohnson
@jasontwong
@willwm
@technovangelist

@algernon your Ergodox community layout has been completely removed for the above reasons, and it also contains images which we don't want in the repo.

Feel free to submit followup PRs fixing what I've broken :)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team October 1, 2021 14:56
@github-actions github-actions bot added python via Adds via keymap and/or updates keyboard for via support labels Oct 1, 2021
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, PLEASE!

@tzarc tzarc merged commit 928d9f9 into qmk:develop Oct 31, 2021
@fauxpark fauxpark deleted the complex-fn-actions-remove branch October 31, 2021 22:41
ptrxyz pushed a commit to ptrxyz/qmk_firmware that referenced this pull request Apr 9, 2022
* Remove complex `fn_actions` macros

* Remove additional `KC_FN*` instances
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement keymap python via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants