Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keymap] Initial simple keymap for ForeverAnApple #14654

Merged
merged 3 commits into from
Nov 20, 2021
Merged

[Keymap] Initial simple keymap for ForeverAnApple #14654

merged 3 commits into from
Nov 20, 2021

Conversation

ForeverAnApple
Copy link

New keymap for ForeverAnApple.

Description

Initial simple keymap for ForeverAnApple.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • N/A

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

drashna
drashna requested changes Oct 5, 2021
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename the folder to be all lower case, as some OSes don't handle mixed casing well.

@drashna drashna requested a review from a team October 11, 2021 02:34
@ForeverAnApple
Copy link
Author

Hi @fauxpark, would you have a moment to take a look at this PR?

@drashna drashna merged commit eff9288 into qmk:master Nov 20, 2021
beelzebubi pushed a commit to beelzebubi/qmk_firmware that referenced this pull request Nov 21, 2021
@ForeverAnApple @fauxpark
[Keymap] Initial simple keymap for ForeverAnApple (qmk#14654)
b31420c 
Co-authored-by: Ryan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ForeverAnApple @drashna @fauxpark