Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Keyboard] Enable CTPC defaults for SplitKB Kyria #14490

Merged
merged 8 commits into from
Oct 2, 2021

Conversation

drashna
Copy link
Member

@drashna drashna commented Sep 18, 2021

Description

Adds default configurations for using the Convert to Proton C configuration so that all features work.

Includes documentation on how to mod the board to wire everything up.

Targeting develop since it needs the post_rules.mk to properly handle everything.

Types of Changes

  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team September 18, 2021 07:28
@drashna drashna changed the title Keyboard/kyria ctpc [Keyboard] Enable CTPC defaults for SplitKB Kyria Sep 18, 2021
keyboards/splitkb/kyria/readme.md Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team September 20, 2021 02:40
@drashna drashna force-pushed the keyboard/kyria_ctpc branch from 30437ee to 4a955e0 Compare September 22, 2021 04:39
@splitkb
Copy link
Contributor

splitkb commented Oct 2, 2021

Very nice addition, thank you very much for the contribution @drashna!

@drashna drashna merged commit 5b644af into qmk:develop Oct 2, 2021
@drashna drashna deleted the keyboard/kyria_ctpc branch October 2, 2021 02:11
ptrxyz pushed a commit to ptrxyz/qmk_firmware that referenced this pull request Apr 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants