Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove BLUETOOTH_ENABLE from keyboard-level rules.mk #14379

Merged
merged 9 commits into from
Sep 12, 2021
Merged

Remove BLUETOOTH_ENABLE from keyboard-level rules.mk #14379

merged 9 commits into from
Sep 12, 2021

Conversation

fauxpark
Copy link
Member

Description

Except where BLUETOOTH_ENABLE is yes or BLUETOOTH is set - those few will eventually (in develop) be changed to eg.

BLUETOOTH_ENABLE = yes
BLUETOOTH_DRIVER = AdafruitBLE|RN42

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team September 11, 2021 02:51
@fauxpark fauxpark changed the title Remove BLUETOOTH_ENABLE from keyboard-level rules.mk, 0-9 Remove BLUETOOTH_ENABLE from keyboard-level rules.mk Sep 11, 2021
@fauxpark fauxpark merged commit 5af1799 into qmk:master Sep 12, 2021
@fauxpark fauxpark deleted the remove-keyboard-rules-bluetooth branch September 12, 2021 05:27
cori pushed a commit to cori/qmk_firmware that referenced this pull request Sep 19, 2021
@fauxpark @cori
Remove BLUETOOTH_ENABLE from keyboard-level rules.mk (qmk#14379)
96e2250
sar23b pushed a commit to sar23b/qmk_firmware that referenced this pull request Sep 19, 2021
@fauxpark
Remove BLUETOOTH_ENABLE from keyboard-level rules.mk (qmk#14379)
e16f835
billyjbryant pushed a commit to MetalBoards/qmk_firmware that referenced this pull request Sep 29, 2021
@fauxpark
Remove BLUETOOTH_ENABLE from keyboard-level rules.mk (qmk#14379)
164a8e7
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@fauxpark @nhongooi
Remove BLUETOOTH_ENABLE from keyboard-level rules.mk (qmk#14379)
81f3b23
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@fauxpark
Remove BLUETOOTH_ENABLE from keyboard-level rules.mk (qmk#14379)
2110442
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
enhancement keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fauxpark @drashna