Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map PRODUCT define to keyboard_name #14372

Merged
merged 3 commits into from
Nov 4, 2021
Merged

Map PRODUCT define to keyboard_name #14372

merged 3 commits into from
Nov 4, 2021

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Sep 10, 2021 •
edited
Loading

Description

And restore the original behaviour of the LUFA bootloader header generation.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested review from skullydazed and a team September 10, 2021 05:21
@fauxpark
Copy link
Member Author 

⚠ handwired/pytest/basic: PRODUCT in config.h is overwriting keyboard_name in info.json

:(

@fauxpark fauxpark changed the base branch from master to develop September 23, 2021 18:20
@tzarc tzarc merged commit 9401836 into qmk:develop Nov 4, 2021
@fauxpark fauxpark deleted the info-keyboard-name-mapping branch November 5, 2021 02:42
ptrxyz pushed a commit to ptrxyz/qmk_firmware that referenced this pull request Apr 9, 2022
@fauxpark @ptrxyz
Map PRODUCT define to keyboard_name (qmk#14372)
c870362 
* Map `PRODUCT` define to `keyboard_name`

* Fix tests

* Fix last test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

@jackhumbert jackhumbert jackhumbert approved these changes

@skullydazed skullydazed Awaiting requested review from skullydazed

Assignees
No one assigned
Labels
bug cli qmk cli command enhancement keyboard python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fauxpark @jackhumbert @tzarc