Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RGBW support to PWM and SPI drivers for ChibiOS #14327

Merged
merged 2 commits into from
Sep 18, 2021

Conversation

drashna
Copy link
Member

@drashna drashna commented Sep 6, 2021

Description

Adds support for RGBW LEDs to the PWM and SPI Drivers for ChibiOS.

PWM driver has support added upstream, so mirrors that.
SPI driver doesn't, but appears to be able to support it, with minimal modification.

Todo: Test changes.

Types of Changes

  • Core
  • Enhancement/optimization

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Sep 6, 2021
@drashna drashna requested a review from a team September 6, 2021 06:09
platforms/chibios/drivers/ws2812_pwm.c Outdated Show resolved Hide resolved
platforms/chibios/drivers/ws2812_pwm.c Outdated Show resolved Hide resolved
platforms/chibios/drivers/ws2812_spi.c Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team September 6, 2021 13:25
@drashna drashna marked this pull request as ready for review September 8, 2021 02:00
@drashna drashna requested a review from fauxpark September 8, 2021 02:25
@fauxpark fauxpark requested a review from a team September 8, 2021 02:43
@tzarc tzarc merged commit 7c10d00 into qmk:develop Sep 18, 2021
@drashna drashna deleted the core/rgbw_support branch September 18, 2021 07:44
cadusk pushed a commit to cadusk/qmk_firmware that referenced this pull request Sep 19, 2021
* qmk/develop: (24 commits)
  [Keyboard] Fix BT rules for dosa40rgb (qmk#14497)
  [Keyboard] Add Gentleman65 (qmk#12971)
  [Keyboard] Add new keyboard quick17 (qmk#13703)
  [Keyboard] Add superuser keyboard (qmk#13840)
  [Keyboard] Add dyz60 (qmk#13864)
  [Keymap] GMMK Pro keymap (qmk#14389)
  [Keyboard] Add support for Coarse60 (qmk#14416)
  [Keymap] Added Brazilian keymap for BM40RGB (qmk#14431)
  [Keyboard] Fix dosa40rgb compilation issues (qmk#14491)
  Improvements to handling of disconnected split keyboards. (qmk#14033)
  Add RGBW support to PWM and SPI drivers for ChibiOS (qmk#14327)
  [Keymap] Add 'j4ckofalltrades' keymap for sofle/rev1 (qmk#14446)
  [Keyboard] Add Dosa40RGB + dtisaac01 (qmk#14476)
  [Keymap] Major Updates to Personal Kyria Keymap (qmk#14485)
  fix link error for helix/rev3_5rows:five_rows (qmk#14466)
  Nix Studio OXALYS80 Refactor (qmk#14473)
  [Keyboard] Move Planck EZ off 'Proton C' board (qmk#14479)
  [Keyboard] Move Moonlander off 'Proton C' board (qmk#14478)
  Update rules.mk for xbows keyboard  (qmk#14477)
  [Keymap] Adding personal keymap (qmk#14326)
  ...
ptrxyz pushed a commit to ptrxyz/qmk_firmware that referenced this pull request Apr 9, 2022
* Add RGBW support to PWM and SPI drivers for ChibiOS

* Apply suggestions from code review

Co-authored-by: Ryan <[email protected]>

Co-authored-by: Ryan <[email protected]>
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
* Add RGBW support to PWM and SPI drivers for ChibiOS

* Apply suggestions from code review

Co-authored-by: Ryan <[email protected]>

Co-authored-by: Ryan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants