Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stream cheap via fixes/updates #14325

Merged
merged 13 commits into from
Nov 10, 2021
Merged

Stream cheap via fixes/updates #14325

merged 13 commits into from
Nov 10, 2021

Conversation

luigi311
Copy link

@luigi311 luigi311 commented Sep 5, 2021

Description

Update the USB Device descriptor parameter for stream_cheaps on all 3 variants to be consistent with each other
Set reasonable defaults for VIA keymaps

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Sep 5, 2021
@stale
Copy link

stale bot commented Oct 24, 2021

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@luigi311
Copy link
Author

This is just need to be merged.

Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you have some merge conflicts that need fixing.

@stale stale bot removed the awaiting changes label Oct 26, 2021
@luigi311
Copy link
Author

luigi311 commented Oct 27, 2021

Ahhh i was wondering why i was getting a conflict, looks like they went through and deleted the json file here #14274 Since via support has now been added i do not believe we need the json to exist anymore so i went ahead and deleted it. It should be ready to go now

@drashna drashna requested a review from a team October 27, 2021 21:17
@github-actions github-actions bot added the CI label Nov 9, 2021
This reverts commit f288534, reversing
changes made to c93db28.
@github-actions github-actions bot removed the CI label Nov 9, 2021
@drashna drashna requested a review from a team November 10, 2021 15:49
@drashna drashna merged commit 3de7008 into qmk:develop Nov 10, 2021
@drashna
Copy link
Member

drashna commented Nov 10, 2021

Thanks!

cadusk pushed a commit to cadusk/qmk_firmware that referenced this pull request Nov 10, 2021
* qmk/develop: (100 commits)
  [Keyboard] Fix compilation issues for teleport numpad (qmk#15110)
  [Keyboard] Add Paroxysm keyboard to Cradio (qmk#15097)
  [Keyboard] Update mb44.h (qmk#15092)
  [Keyboard] Stream cheap via fixes/updates (qmk#14325)
  [Keyboard] PK64RGB Keyboard Addition (qmk#14627)
  [Keyboard] Element Hotswap PCB (qmk#15082)
  [Keyboard] Teleport numpad (qmk#14905)
  Updates to drashna keymap and minor updates to tractyl manuform (qmk#15101)
  Update noroadsleft userspace and keymaps (2021-11-09) (qmk#15099)
  Mechlovin Pisces Refactor (qmk#15080)
  idb 60 Layout Macro Refactor (qmk#15079)
  [Keyboard] Add new keyboard "Heavy Left" (qmk#15052)
  Fixup broken build after qmk#15040 (qmk#15073)
  [Keyboard] Add VIA to Gud70 (qmk#15071)
  [Keyboard] Fix compilation issues for superuser tkl (qmk#15070)
  [Keyboard] Add Ziggurat keyboard (qmk#15008)
  Update updated KPrepublic boards to be prepared for the update (qmk#15040)
  [Keymap] add keymap for xd60 (qmk#15053)
  [Keymap] Revamp the ergodox french_hacker layout (qmk#15064)
  kprepublic/bm65rgb/rev1: Fix info.json (qmk#15066)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants