Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keyboard/miniashen40 #14238

Merged
merged 17 commits into from
Nov 19, 2021
Merged

Keyboard/miniashen40 #14238

merged 17 commits into from
Nov 19, 2021

Conversation

jfescobar18
Copy link

@jfescobar18 jfescobar18 commented Aug 30, 2021 •
edited by zvecr
Loading

Description

New keyboard added, already tested and working with physical device, and functional prototype

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Aug 30, 2021
zvecr
zvecr requested changes Aug 30, 2021
View reviewed changes
keyboards/mechanickeys/miniashen40/README.md Outdated Show resolved Hide resolved
keyboards/mechanickeys/miniashen40/README.md Outdated Show resolved Hide resolved
keyboards/mechanickeys/miniashen40/rules.mk Outdated Show resolved Hide resolved
@jfescobar18 jfescobar18 requested a review from zvecr August 30, 2021 20:07
@jfescobar18 jfescobar18 requested a review from drashna September 1, 2021 06:43
@drashna drashna requested a review from a team September 2, 2021 04:05
@jfescobar18 jfescobar18 requested a review from fauxpark September 2, 2021 04:29
@stale
Copy link

stale bot commented Oct 24, 2021

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

fauxpark
fauxpark requested changes Oct 24, 2021
View reviewed changes
keyboards/mechanickeys/miniashen40/rules.mk Outdated Show resolved Hide resolved
keyboards/mechanickeys/miniashen40/rules.mk Outdated Show resolved Hide resolved
keyboards/mechanickeys/miniashen40/README.md Outdated Show resolved Hide resolved
keyboards/mechanickeys/miniashen40/README.md Outdated Show resolved Hide resolved
@stale stale bot removed the awaiting changes label Oct 24, 2021
@jfescobar18
Copy link
Author

jfescobar18 commented Nov 2, 2021 •
edited
Loading

Any updated on this?
@zvecr ?

@jfescobar18
Copy link
Author

@drashna @fauxpark @zvecr

Any update??

@drashna
Copy link
Member

drashna commented Nov 19, 2021

Sorry about that.

And thanks!

@drashna drashna merged commit d2b2069 into qmk:master Nov 19, 2021
@jfescobar18 jfescobar18 mentioned this pull request Nov 19, 2021
Merged
6 tasks
beelzebubi pushed a commit to beelzebubi/qmk_firmware that referenced this pull request Nov 21, 2021
@jfescobar18 @zvecr @fauxpark
[Keyboard] Add miniashen40 (qmk#14238)
a66eb0f 
Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: Ryan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

@zvecr zvecr Awaiting requested review from zvecr

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jfescobar18 @drashna @fauxpark @zvecr