Fix number of elements in info.json does not match errors #14213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you are tagged in this comment you have a keyboard changed in this PR: @evyd13 @joedinkle @stevendlander @jackytrabbit @melgeek001365 @yiancar @mm0nte @2Moons-JP @projectcain @Sleepdealr @vanillakeyboards |
|
@skullydazed the problem with the atom47 seems to be in the matrix definition, not the info.json. Should I open a PR to fix that instead? |
fauxpark
approved these changes
Aug 29, 2021
Whatever is easiest for you works for me, as long as we clear up the lint errors. I can remove these changes in favor of a separate PR from you, or you can PR against this branch. |
skullydazed
force-pushed
the
fix_layout_elements
branch
from
b2f58ba to
d4b1043
Compare
skullydazed
force-pushed
the
fix_layout_elements
branch
from
d4b1043 to
d701e9e
Compare
14 tasks
cadusk
pushed a commit
to cadusk/qmk_firmware
that referenced
this pull request
Sep 10, 2021
* qmk/develop: (31 commits) Remove BLUETOOTH_ENABLE from defaultish keymaps (qmk#14375) Change USBasp and bootloadHID bootloaders to lowercase (qmk#14354) Move non-assignment code to post_rules.mk (qmk#14207) Fix number of elements in info.json does not match errors (qmk#14213) Remove bootloader listings from rules.mk (qmk#14330) Remove commented out BLUETOOTH_ENABLE rules (qmk#14361) Align rgb/led matrix docs with current behaviour (qmk#14367) [Keyboard] Add custom pcb for Polaris (qmk#14347) Fix CRLF in lyra/rev1 (qmk#14360) [Keyboard] add lyra (qmk#13977) [Keyboard] Add Olly JF PCB (qmk#14056) Backport F_CPU/F_USB hack from system76 (qmk#14286) [Keymap] Fix Maker Keyboards Alexa Keymap (qmk#14355) [Keyboard] Add 61Key (qmk#14259) `ST7565_TIMEOUT 0` and `ST7565_DISABLE_TIMEOUT` should behave the same (qmk#14315) `OLED TIMEOUT 0` and `OLED_DISABLE_TIMEOUT` should behave the same (qmk#14302) [Keyboard] Minor tweaks to Work Board layout (qmk#14351) Bugfix for Joystick and JSON schema (qmk#14295) [Keyboard] Add new Mokey keyboard (qmk#14329) [Keymap] Add Gaston's Lily58 custom keymap (qmk#14334) ...
ptrxyz
pushed a commit
to ptrxyz/qmk_firmware
that referenced
this pull request
Apr 9, 2022
* evyd13/atom47/rev3: best guess at fixing info.json * evyd13/atom47: best guess at fixing info.json * eyeohdesigns/sprh: best guess at fixing info.json * handwired/unicomp_mini_m: best guess at fixing info.json * lazydesigners/the60/rev2: best guess at fixing info.json * melgeek/mj6xy: best guess at fixing info.json * pizzakeyboards/pizza65: best guess at fixing info.json * plx: best guess at fixing info.json * rojectcain/vault45: best guess at fixing info.json * sidderskb/majbritt/rev2: best guess at fixing info.json * spacey: best guess at fixing info.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes the number of elements in info.json match the number of elements in the C layout.
Types of Changes
Checklist