Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebase usb host based on hasu's fork and corresponding changes to usb_usb #14154

Closed
wants to merge 2 commits into from

Conversation

milestogo
Copy link
Contributor

Description

Delete out of date usb host shield 2.0 library, and submodule the master branch of Hasu's port. Hasu has been doing a lot of work to better detect HID devices. I have two keyboards that are not recognized without these changes.

I did not update the arduino library, and left changes to the serial library overrides commented out.

The rest is diffed from the current TMK usb_usb files, keeping QMK debugging & making changes to use usbhid.x instead of hid.x .

Tested on a hasu usb_usb device with a TEK cleave keyboard (badly behaved), and several QMK keyboards (well behaved).

I've never created submodules before, so that's likely to be wrong.

Fauxpark didn't take this approach in #13973 , there may be good reasons

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • backport of code used in current TMK.

Checklist

  • [x ] My code follows the code style of this project: [C]
  • [ x] I have read the [PR Checklist document]
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • [ x] I have read the [CONTRIBUTING document]
  • I have added tests to cover my changes.
  • [x ] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr
Copy link
Member

zvecr commented Aug 25, 2021

The long term plans are to remove all the arduino code, including the host shield lib. The main reason is its rather bodged in, working on limited MCUs and conflicting with various parts of the QMK codebase.

The intention is to introduce drivers based on spi_master, to provide a better integration.

@@ -22,3 +22,6 @@
[submodule "lib/printf"]
path = lib/printf
url = https://github.com/qmk/printf
[submodule "lib/usbhost/USB_Host_Shield_2.0"]
path = lib/usbhost/USB_Host_Shield_2.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just:

Suggested change
path = lib/usbhost/USB_Host_Shield_2.0
path = lib/USB_Host_Shield_2.0

@milestogo
Copy link
Contributor Author

Since this is a library/core feature, I'm going to need core maintainers to figure out what happens next.

@stale
Copy link

stale bot commented Oct 30, 2021

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@tzarc
Copy link
Member

tzarc commented Nov 1, 2021

Unsure what the status is, but it looks like there's a longer-term direction at play here.
Swapping about the labels so stalebot doesn't close it.

@drashna drashna requested a review from a team December 11, 2021 18:18
@tzarc tzarc closed this Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants