Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keymap] fix helix:fraanrosi compile error caused by #13677. #14061

Merged
merged 1 commit into from
Aug 19, 2021
Merged

[Keymap] fix helix:fraanrosi compile error caused by #13677. #14061

merged 1 commit into from
Aug 19, 2021

Conversation

mtei
Copy link
Contributor

@mtei mtei commented Aug 18, 2021

Description

I'm against using RGBLIGHT_ANIMATIONS because this happens.
See also #8688.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@mtei
[Keymap] fix helix:fraanrosi compile error caused by qmk#13677.
07a5c15 
I'm against using RGBLIGHT_ANIMATIONS because this happens.
See also qmk#8688.
@mtei mtei requested review from tzarc and a team August 18, 2021 11:21
@mtei mtei merged commit f86a087 into qmk:develop Aug 19, 2021
@mtei mtei deleted the fix_helix_fraanrosi_keymap branch August 27, 2021 12:25
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@mtei @nhongooi
[Keymap] fix helix:fraanrosi compile error caused by qmk#13677. (qmk#…
595a93d 
…14061)

I'm against using RGBLIGHT_ANIMATIONS because this happens.
See also qmk#8688.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@tzarc tzarc Awaiting requested review from tzarc

Assignees
No one assigned
Labels
keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mtei @fauxpark