Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add h08_ocelot and h65 PCBs #14054

Merged
merged 48 commits into from
Feb 20, 2022
Merged

Add h08_ocelot and h65 PCBs #14054

merged 48 commits into from
Feb 20, 2022

Conversation

hineybush
Copy link
Contributor

@hineybush hineybush commented Aug 18, 2021

Description

Firmware for the h08, currently only used on the upcoming version of the Singa Ocelot.

Also adding my h65, both versions - soldereable and hotswap. Currently using different firmware because the split spacebar matrix assignments are different.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • [] My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Aug 18, 2021
keyboards/hineybush/h08_ocelot/config.h Outdated Show resolved Hide resolved
keyboards/hineybush/h65/config.h Outdated Show resolved Hide resolved
keyboards/hineybush/h08_ocelot/readme.md Show resolved Hide resolved
keyboards/hineybush/h08_ocelot/readme.md Outdated Show resolved Hide resolved
keyboards/hineybush/h65/keymaps/via/keymap.c Show resolved Hide resolved
@hineybush
Copy link
Contributor Author

oh no i just realized i was on the wrong branch for the h08 stuff and it pushed all of my other in-development h65 stuff, help

keyboards/hineybush/h65/readme.md Show resolved Hide resolved
keyboards/hineybush/h65_hotswap/readme.md Outdated Show resolved Hide resolved
keyboards/hineybush/h65_hotswap/readme.md Show resolved Hide resolved
keyboards/hineybush/h65_hotswap/rules.mk Outdated Show resolved Hide resolved
keyboards/hineybush/h65/rules.mk Outdated Show resolved Hide resolved
@stale
Copy link

stale bot commented Oct 30, 2021

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@stale stale bot removed the awaiting changes label Nov 11, 2021
@hineybush hineybush changed the title Add h08_ocelot PCB Add h08_ocelot and h65 PCBs Nov 11, 2021
@hineybush
Copy link
Contributor Author

@drashna finally made updates to this, lol

keyboards/hineybush/h65_hotswap/config.h Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team November 15, 2021 04:40
keyboards/hineybush/h65_hotswap/rules.mk Outdated Show resolved Hide resolved
keyboards/hineybush/h65_hotswap/rules.mk Outdated Show resolved Hide resolved
keyboards/hineybush/h65_hotswap/readme.md Outdated Show resolved Hide resolved
keyboards/hineybush/h65_hotswap/info.json Outdated Show resolved Hide resolved
keyboards/hineybush/h65_hotswap/info.json Outdated Show resolved Hide resolved
keyboards/hineybush/h65_hotswap/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/hineybush/h65_hotswap/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/hineybush/h65_hotswap/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/hineybush/h65_hotswap/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/hineybush/h65_hotswap/h65_hotswap.h Outdated Show resolved Hide resolved
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the suggestions here are basically:

  • rules.mk clean-up to match QMK's template
  • #define DYNAMIC_KEYMAP_LAYER_COUNT 3 for VIA support
  • rename the layout macros to LAYOUT_all because the boards support multiple layouts

GitHub tip: You can apply multiple suggestions to a single commit by using the Files Changed tab.

keyboards/hineybush/h08_ocelot/rules.mk Outdated Show resolved Hide resolved
keyboards/hineybush/h65/h65.h Outdated Show resolved Hide resolved
keyboards/hineybush/h65/config.h Show resolved Hide resolved
keyboards/hineybush/h65/info.json Outdated Show resolved Hide resolved
keyboards/hineybush/h65/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/hineybush/h65_hotswap/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/hineybush/h65_hotswap/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/hineybush/h65_hotswap/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/hineybush/h65_hotswap/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/hineybush/h65_hotswap/rules.mk Outdated Show resolved Hide resolved
@hineybush
Copy link
Contributor Author

Forgot I could push multiple suggestions on the files changed tab. oops lol

@noroadsleft noroadsleft merged commit 38e3be4 into qmk:master Feb 20, 2022
@noroadsleft
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants