Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors that have cropped up in develop #14005

Merged
merged 2 commits into from
Aug 15, 2021
Merged

Fix errors that have cropped up in develop #14005

merged 2 commits into from
Aug 15, 2021

Conversation

skullydazed
Copy link
Member

@skullydazed skullydazed commented Aug 14, 2021

Description

These keyboards were added to master recently. This brings our error count back to 0.

⚠ frooastboard: DEBOUNCE in config.h is overwriting debounce in info.json
⚠ frooastboard: DEVICE_VER in config.h is overwriting usb.device_ver in info.json
⚠ frooastboard: DIODE_DIRECTION in config.h is overwriting diode_direction in info.json
⚠ frooastboard: PRODUCT_ID in config.h is overwriting usb.pid in info.json
⚠ frooastboard: VENDOR_ID in config.h is overwriting usb.vid in info.json
⚠ frooastboard: Matrix pins are specified in both info.json and config.h, the config.h values win.
☒ pistachio_pro: MATRIX_COLS is inconsistent with the size of MATRIX_COL_PINS: 11 != 18

Types of Changes

  • Bugfix
  • Keyboard (addition or update)

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • I have read the CONTRIBUTING document.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@skullydazed skullydazed requested a review from a team August 14, 2021 16:47
@skullydazed
Copy link
Member Author

@7-rate could you comment on the change to pistachio_pro here? It looks to me like pin D5 is not actually used, because the pin is excluded from the matrix scanning by the MATRIX_COLS / 2 snippet in your for loops.

@7-rate
Copy link
Contributor

7-rate commented Aug 15, 2021

@skullydazed thank you.
The D5 pin was a mistake.
Just in case, I checked the operation with the proposed change and confirmed that there was no problem.

@tzarc tzarc merged commit 8a54127 into develop Aug 15, 2021
@tzarc tzarc deleted the fix_errors branch August 15, 2021 01:02
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
* frooastboard: remove duplicate values from config.h

* pistachio_pro: remove unused pin D5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants