Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infer more when building features #13890

Merged
merged 2 commits into from
Oct 17, 2021
Merged

Infer more when building features #13890

merged 2 commits into from
Oct 17, 2021

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Aug 4, 2021 •
edited
Loading

Description

The long term Idea explored is to automatically:

  1. compile quantum/process_keycode/process_<feature>.c if it exists
  2. compile quantum/<feature>.c if it exists
  3. add an <feature>_ENABLE define

This could help cut down a lot of the repetative boilerplate in common_features.mk

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Aug 4, 2021
noroadsleft
noroadsleft approved these changes Aug 18, 2021
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

__attribute__ ((weak)) ✔️

@zvecr zvecr force-pushed the feature/generic_feature branch from 1ed783a to 1445cc1 Compare August 18, 2021 17:18
@github-actions github-actions bot added CI documentation keyboard keymap translation via Adds via keymap and/or updates keyboard for via support labels Aug 18, 2021
@zvecr zvecr changed the base branch from master to develop August 18, 2021 17:19
@github-actions github-actions bot removed keymap via Adds via keymap and/or updates keyboard for via support translation CI documentation keyboard labels Aug 18, 2021
@zvecr zvecr force-pushed the feature/generic_feature branch from 0613903 to b63ea12 Compare August 18, 2021 18:01
@drashna drashna requested a review from a team August 19, 2021 18:14
@zvecr zvecr removed the in progress label Aug 26, 2021
@zvecr zvecr marked this pull request as ready for review August 26, 2021 16:28
@stale
Copy link

stale bot commented Oct 11, 2021

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@zvecr zvecr force-pushed the feature/generic_feature branch from b63ea12 to 5cf0a02 Compare October 16, 2021 02:09
@stale stale bot removed the awaiting changes label Oct 16, 2021
@zvecr zvecr force-pushed the feature/generic_feature branch from e86668d to 2b5c990 Compare October 16, 2021 03:11
@zvecr zvecr force-pushed the feature/generic_feature branch from 2b5c990 to b55c53e Compare October 17, 2021 18:51
@zvecr zvecr mentioned this pull request Oct 17, 2021
Merged
14 tasks
@zvecr zvecr merged commit bd2f8ab into qmk:develop Oct 17, 2021
cadusk pushed a commit to cadusk/qmk_firmware that referenced this pull request Oct 19, 2021
Merge remote-tracking branch 'qmk/develop' into develop
c1d4d46 
* qmk/develop: (26 commits)
  [DOCS] Fix the STENO_COMBINEDMAP table (qmk#14883)
  Fix builds for ChibiOS + Cortex-M0[+] (qmk#14879)
  Split out HAPTIC_ENABLE to have separate DRIVER option (qmk#14854)
  [Core] Add support for RISC-V builds and GD32VF103 MCU (qmk#12508)
  Add HT32 support to core (qmk#14388)
  preonic/rev3_drop: Fix old custom matrix code (qmk#14857)
  Remove legacy Makefile functionality (qmk#14858)
  Infer more when building features (qmk#13890)
  [Keymap] added media controls, copy and paste; moved print screen (qmk#14850)
  [Keyboard] Add SpiderIsland 25 key keyboard (qmk#14793)
  [Keyboard] Update Support for The Uni (qmk#14569)
  Try to clarify "number of elements in info.json does not match" error (qmk#14844)
  [Keyboard] Fix minor typo in Ploopy Trackball Nano Docs (qmk#14717)
  add docs/ja/ja_doc_status.sh (qmk#14402)
  [Keyboard] Amended Some Pins - KiwiKeebs Macro V2 (qmk#14824)
  [Keyboard] Adding CK60 and CK65 (qmk#14737)
  [Keymap] Update Miryoku (qmk#14827)
  [Keymap] Drashna Keymap Updates (qmk#14842)
  [Keyboard] Tractyl Manuform Updates (qmk#14841)
  [Keymap] Added GMMK Pro keymap with RGB  (qmk#14648)
  ...
ptrxyz pushed a commit to ptrxyz/qmk_firmware that referenced this pull request Apr 9, 2022
@zvecr @ptrxyz
Infer more when building features (qmk#13890)
1c700d9
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@zvecr
Infer more when building features (qmk#13890)
037428b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noroadsleft noroadsleft noroadsleft approved these changes

@tzarc tzarc tzarc approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zvecr @drashna @tzarc @noroadsleft