Ardakilic keymap for crkbd added

[Ardakilic]

Description

My keymap for Corne keyboard. This keymap is optimized for typing Turkish while covering my needs for programming, and is similar to #7643 and #7151

Types of Changes

• Core
• Bugfix
• New feature
• Enhancement/optimization
• Keyboard (addition or update)
• Keymap/layout/userspace (addition or update)
• Documentation

Issues Fixed or Closed by This PR

• None

Checklist

• My code follows the code style of this project: C, Python
• I have read the PR Checklist document and have made the appropriate changes.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• I have tested the changes and verified that they work and don't break anything (as well as I can manage).

[Ardakilic]

CONSOLE_ENABLE=no did not help for my case. My initial lines for size optimisation work though.

I have also added

EXTRAFLAGS+=-flto

to my rules.mk file, and added

#define NO_ACTION_MACRO
#define NO_ACTION_FUNCTION

to my config.h file. Now it fits.

Please check my last commits. I wonder why disabling console does not reduce the size like my initial commit though.

[drashna]

No need to add those. LTO_ENABLE = yes does both of those, actually

[drashna]

Also, you may want to remove snprint/sprint, because this can take up a LOT of space in the firmwar (1.5kb or more).

For rendering numbers, this may be more verbose, but ...

    uint8_t n = get_current_wpm();
    char wpm_counter[4];
    wpm_counter[3] = '\0';
    wpm_counter[2] = '0' + n % 10;
    wpm_counter[1] = (n /= 10) % 10 ? '0' + (n) % 10 : (n / 10) % 10 ? '0' : ' ';
    wpm_counter[0] = n / 10 ? '0' + n / 10 : ' ';
    oled_write_P(PSTR("WPM: "), false);
    oled_write(wpm_counter, false);

This renders a 3 digit character, using the WPM value, and removes empty values (eg 5 vs 005). And this uses ~1.5KB less than using snprintf to do the same.

[stale]

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

[Ardakilic]

OK, anythingh else I need to address to? cc/ @drashna @fauxpark

[stale]

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

[Ardakilic]

Are you waiting any further changes from me ?

[stale]

Thank you for your contribution!
This pull request has been automatically closed because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, or re-open when it's ready.

[Ardakilic]

Apologies for the bump @drashna , this PR had been stale while awaiting for review, and bot auto closed it. @fauxpark approved this, any reason this is left dormant, or won't this be merged ?

Thanks,

[Ardakilic]

Thanks for the review and merge! 🙏