Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up some Cannon Keys boards #13715

Merged
merged 1 commit into from
Jul 27, 2021
Merged

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Jul 26, 2021

Description

  • keyboard.c
    • matrix_init_kb not calling _user (was just flashing led on startup which im guessing was more important for previous debugging).
  • ws2812.c
    • no longer used

@awkannan

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr marked this pull request as ready for review July 26, 2021 20:03
@zvecr zvecr merged commit 7ac7ca9 into qmk:develop Jul 27, 2021
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants