Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing info.json for h0oni/hotduck #13640

Merged
merged 9 commits into from
Jul 22, 2021
Merged

Fixing info.json for h0oni/hotduck #13640

merged 9 commits into from
Jul 22, 2021

Conversation

h0oni
Copy link

@h0oni h0oni commented Jul 22, 2021

Description

The info.json had some minor issues for backspace and rshft keys.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

h0oni added 7 commits July 20, 2021 08:47
Changes been made according to Drashna's comment.
Re-arranging the layouts according to the physical layout.
fauxpark's requested changes
@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jul 22, 2021
@h0oni h0oni closed this Jul 22, 2021
@h0oni h0oni deleted the h0oni branch July 22, 2021 08:09
@h0oni h0oni restored the h0oni branch July 22, 2021 08:09
@h0oni h0oni reopened this Jul 22, 2021
Fixed the y value for del, home, pgdwn
@drashna
Copy link
Member

drashna commented Jul 22, 2021

You have a merge conflict here.

Need to merge or rebase

@github-actions github-actions bot removed via Adds via keymap and/or updates keyboard for via support keymap labels Jul 22, 2021
@h0oni
Copy link
Author

h0oni commented Jul 22, 2021

The conflicts were handled.

@fauxpark fauxpark requested a review from a team July 22, 2021 10:54
@drashna
Copy link
Member

drashna commented Jul 22, 2021

Thanks!

@drashna drashna merged commit 58abdfc into qmk:master Jul 22, 2021
cadusk pushed a commit to cadusk/qmk_firmware that referenced this pull request Jul 22, 2021
* qmk/develop: (141 commits)
  Implement GPIO abstraction for atsam (qmk#13567)
  [Keyboard][Bug] Add timer_avr to includes for broken builds (qmk#13641)
  [Keyboard] adds new revision: dztech/dz60rgb/v2_1 (qmk#13636)
  [Keyboard] Fixing info.json for h0oni/hotduck (qmk#13640)
  [Keyboard] Ymd40v2new layouts and fixed per-switch backlight (qmk#13622)
  [Bug] Develop - DC01 left (qmk#13597)
  [Keyboard] Fix clawsome/hatchback and reviung5 compile issues (qmk#13607)
  [Keyboard] add ogurec (qmk#13242)
  [Keyboard] Add Durgod Taurus K310 keyboard (qmk#12314)
  [Keyboard] Updated keyboard & keymaps (qmk#12667)
  [Keyboard] add SPRH keyboard (qmk#12999)
  Retain brightness with lighting layers (qmk#13025)
  [Keyboard] Add keypad Satxri6key (qmk#13423)
  [Keyboard] Initial Tron Guy Labs keyboard implementation. (qmk#13438)
  [Keyboard] Add Ristretto Keyboard (qmk#13479)
  [Keyboard] New Keyboard - OBE (qmk#13545)
  [Keyboard] Add personal planck keymap (qmk#13635)
  [Keymap] narze/xd004 (qmk#13634)
  [Keyboard] Add h0oni hotduck keyboard (qmk#13609)
  Fix API generation failure caused by GRS-70EC (qmk#13631)
  ...
@h0oni h0oni deleted the h0oni branch July 23, 2021 07:56
@h0oni h0oni restored the h0oni branch July 23, 2021 15:46
@zvecr zvecr mentioned this pull request Jul 23, 2021
14 tasks
@h0oni h0oni deleted the h0oni branch July 24, 2021 05:30
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants