Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow output of logging when running unit tests #13556

Merged
merged 5 commits into from
Jul 25, 2021
Merged

Allow output of logging when running unit tests #13556

merged 5 commits into from
Jul 25, 2021

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Jul 15, 2021 •
edited
Loading

Description

Can be run with make test:all DEBUG=1.

Should help slightly when trying to diagnose issues.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Jul 15, 2021
@zvecr zvecr mentioned this pull request Jul 15, 2021
Merged
14 tasks
@zvecr zvecr changed the title Initial pass at enabling logging for unit tests Allow output of logging when running unit tests Jul 17, 2021
@zvecr zvecr marked this pull request as ready for review July 17, 2021 23:27
@zvecr zvecr requested a review from a team July 17, 2021 23:27
@zvecr zvecr marked this pull request as draft July 18, 2021 22:13
@zvecr zvecr marked this pull request as ready for review July 18, 2021 22:53
@zvecr zvecr requested review from a team and drashna July 18, 2021 22:53
@drashna drashna requested a review from a team July 24, 2021 15:37
@zvecr zvecr merged commit fc9fb2c into qmk:master Jul 25, 2021
@zvecr zvecr mentioned this pull request Oct 21, 2021
Merged
14 tasks
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@zvecr @nhongooi
Allow output of logging when running unit tests (qmk#13556)
fd1df45 
* Initial pass at enabling logging for unit tests

* Add to docs

* Bind debug for more test types

* Force everything

* Tidy up slightly
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@zvecr
Allow output of logging when running unit tests (qmk#13556)
4fad59f 
* Initial pass at enabling logging for unit tests

* Add to docs

* Bind debug for more test types

* Force everything

* Tidy up slightly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zvecr @drashna