-
-
Notifications
You must be signed in to change notification settings - Fork 40.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix clang unit tests #13546
Fix clang unit tests #13546
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Continuing from #12567 (comment).
The main issue this is trying to solve is clangs limited gcc compatibility. clang can be run on more than systems that report as apple, likewise gcc can work fine on x86 darwin systems. There seems to still be little movement in providing a gcc for apple Arm64.
So would still be keen to pivot the issue from "is apple" to "is clang".
565712b
to
c1c91ac
Compare
@zvecr Ok, updated to check for clang |
On Mac, clang errors out on some flags when attempting to run tests.
Description
On Mac, clang errors out on some flags when attempting to run tests:
clang: error: the clang compiler does not support '-funsigned-bitfields' [-Werror]
clang: error: optimization flag '-fno-inline-small-functions' is not supported [-Werror,-Wignored-optimization-argument]
clang: error: unsupported argument '-adhlns=.build/test_obj/eeprom_stm32/tmk_core/common/test/flash_stm32_mock.lst' to option 'Wa,'
Steps to reproduce:
make test:debounce_sym_defer_g
This change skips including a few non-compatible compiler flags when using clang.
Types of Changes
Issues Fixed or Closed by This PR
Checklist