Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doctor: print CLI version #13356

Merged
merged 1 commit into from
Jun 27, 2021
Merged

Doctor: print CLI version #13356

merged 1 commit into from
Jun 27, 2021

Conversation

fauxpark
Copy link
Member

Description

Now that MILC grabs this correctly we can show it in the doctor output.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team June 26, 2021 17:29
@fauxpark fauxpark merged commit 53ace43 into qmk:master Jun 27, 2021
@fauxpark fauxpark deleted the doctor-print-cli-version branch June 27, 2021 03:21
sperly pushed a commit to sperly/qmk_firmware that referenced this pull request Jul 2, 2021
@fauxpark @sperly
Doctor: print CLI version (qmk#13356)
3584c57
jakeprime pushed a commit to jakeprime/qmk_firmware that referenced this pull request Jul 10, 2021
@fauxpark @jakeprime
Doctor: print CLI version (qmk#13356)
775c17a
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Jul 11, 2021
@fauxpark @HokieGeek
Doctor: print CLI version (qmk#13356)
c8f365c
wox pushed a commit to wox/qmk_firmware that referenced this pull request Aug 14, 2021
@fauxpark @wox
Doctor: print CLI version (qmk#13356)
5982bb7
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@fauxpark @nhongooi
Doctor: print CLI version (qmk#13356)
7594139
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@fauxpark
Doctor: print CLI version (qmk#13356)
bba5bdf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skullydazed skullydazed skullydazed approved these changes

Assignees
No one assigned
Labels
cli qmk cli command enhancement python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fauxpark @skullydazed