Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GON Nerd60 Refactor #13343

Merged
merged 9 commits into from
Jun 26, 2021
Merged

GON Nerd60 Refactor #13343

merged 9 commits into from
Jun 26, 2021

Conversation

noroadsleft
Copy link
Member

Description

Fixes a layout macro issue, adds some more layouts, and tidies up the codebase for this board.

@Mauin, your keymap has been largely reworked, but functionality should be the same.

Thanks to AfterThought#3337 on Discord for debugging and researching.

Types of Changes

  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • I have read the CONTRIBUTING document.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

The K17 position is actually the left half of a split Backspace, rather than the position for Non-US Hash key.

Arranges the layout macro and keycodes to resemble the assembled keyboard.
Corrects the layout data to work with the new layout macro, and removes the key_count JSON key.
Refactors the Grave/Escape key to use `process_record_user()` instead of TMK's `action_function()`.
Add support for the 60_ansi, 60_ansi_split_bs_rshift, 60_iso, and 60_iso_split_bs_rshift community layouts.
keyboards/gon/nerd60/rules.mk Outdated Show resolved Hide resolved
@fauxpark fauxpark merged commit 39b1dc7 into qmk:master Jun 26, 2021
@noroadsleft noroadsleft deleted the rf/gon_nerd60 branch June 26, 2021 02:07
sperly pushed a commit to sperly/qmk_firmware that referenced this pull request Jul 2, 2021
jakeprime pushed a commit to jakeprime/qmk_firmware that referenced this pull request Jul 10, 2021
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Jul 11, 2021
wox pushed a commit to wox/qmk_firmware that referenced this pull request Aug 14, 2021
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants