-
-
Notifications
You must be signed in to change notification settings - Fork 40.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GON Nerd60 Refactor #13343
Merged
Merged
GON Nerd60 Refactor #13343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The K17 position is actually the left half of a split Backspace, rather than the position for Non-US Hash key. Arranges the layout macro and keycodes to resemble the assembled keyboard.
Corrects the layout data to work with the new layout macro, and removes the key_count JSON key.
Refactors the Grave/Escape key to use `process_record_user()` instead of TMK's `action_function()`.
Add support for the 60_ansi, 60_ansi_split_bs_rshift, 60_iso, and 60_iso_split_bs_rshift community layouts.
fauxpark
requested changes
Jun 26, 2021
fauxpark
approved these changes
Jun 26, 2021
sperly
pushed a commit
to sperly/qmk_firmware
that referenced
this pull request
Jul 2, 2021
jakeprime
pushed a commit
to jakeprime/qmk_firmware
that referenced
this pull request
Jul 10, 2021
HokieGeek
pushed a commit
to HokieGeek/qmk_firmware
that referenced
this pull request
Jul 11, 2021
wox
pushed a commit
to wox/qmk_firmware
that referenced
this pull request
Aug 14, 2021
nhongooi
pushed a commit
to nhongooi/qmk_firmware
that referenced
this pull request
Dec 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a layout macro issue, adds some more layouts, and tidies up the codebase for this board.
@Mauin, your keymap has been largely reworked, but functionality should be the same.
Thanks to AfterThought#3337 on Discord for debugging and researching.
Types of Changes
Checklist