Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow LINE_PINxx for Teensy 4.x pins for indicator LEDs as well #13263

Closed
wants to merge 1 commit into from

Conversation

stapelberg
Copy link
Contributor

Description

This is the same change as #13247, but for the indicator LEDs (caps lock etc.).

I only noticed this was missing while preparing another pull request.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested review from skullydazed and a team June 20, 2021 07:48
@skullydazed
Copy link
Member

This PR showed me that we are overdue for implementing refs in our jsonschema, so I did that in #13271. I think that will also solve this problem for you?

@stapelberg
Copy link
Contributor Author

This PR showed me that we are overdue for implementing refs in our jsonschema, so I did that in #13271. I think that will also solve this problem for you?

Yes, I can confirm. When I rebase my keyboard controller PR onto your PR, it also compiles cleanly. Thanks!

@skullydazed
Copy link
Member

Closing in favor of #13271.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants