Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that safe_commands always run #13199

Merged
merged 2 commits into from
Jun 14, 2021
Merged

Ensure that safe_commands always run #13199

merged 2 commits into from
Jun 14, 2021

Conversation

skullydazed
Copy link
Member

Description

If python modules are missing it's not possible to run qmk setup and other safe_commands. This makes sure we can still run those even when we're missing python modules.

Types of Changes

  • Core
  • Bugfix

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • I have read the CONTRIBUTING document.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@skullydazed skullydazed requested a review from a team June 13, 2021 04:07
@github-actions github-actions bot added cli qmk cli command python labels Jun 13, 2021
@skullydazed skullydazed merged commit 0713797 into master Jun 14, 2021
@skullydazed skullydazed deleted the robust_imports branch June 14, 2021 23:52
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Jul 11, 2021
* ensure that safe_commands always run

* import the config subcommand in bin/qmk
wox pushed a commit to wox/qmk_firmware that referenced this pull request Aug 14, 2021
* ensure that safe_commands always run

* import the config subcommand in bin/qmk
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
* ensure that safe_commands always run

* import the config subcommand in bin/qmk
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
* ensure that safe_commands always run

* import the config subcommand in bin/qmk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli qmk cli command python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants