Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GMMK Pro LED map Fix #13189

Merged
merged 1 commit into from
Jun 14, 2021
Merged

GMMK Pro LED map Fix #13189

merged 1 commit into from
Jun 14, 2021

Conversation

Gigahawk
Copy link

@Gigahawk Gigahawk commented Jun 12, 2021 •
edited
Loading

Fixes the mismapped LEDs on GMMK Pro

Description

Corrects the LED indices specified in g_led_config

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added core documentation keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jun 12, 2021
@github-actions github-actions bot removed documentation keymap via Adds via keymap and/or updates keyboard for via support core labels Jun 12, 2021
@tzarc tzarc merged commit fda4149 into qmk:develop Jun 14, 2021
@Gigahawk Gigahawk mentioned this pull request Jun 16, 2021
Closed
14 tasks
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@Gigahawk @nhongooi
Fix LED mapping for GMMK Pro (qmk#13189)
8ab86b9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gigahawk @drashna @tzarc