Change Lufa-MS size #13183
Merged
Change Lufa-MS size #13183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drashna
requested changes
Jun 14, 2021
Co-authored-by: Drashna Jaelre <[email protected]>
14 tasks
|
Changed the bootloader to 8k again since it is already in QMK as Fauxpark said here: #13017 (comment) Also added local overrides for the two boards that use the old 6k bootloader (Tada68 and Cod67) |
fauxpark
approved these changes
Jun 14, 2021
drashna
approved these changes
Jun 14, 2021
HokieGeek
pushed a commit
to HokieGeek/qmk_firmware
that referenced
this pull request
Jul 11, 2021
Co-authored-by: Drashna Jaelre <[email protected]>
wox
pushed a commit
to wox/qmk_firmware
that referenced
this pull request
Aug 14, 2021
Co-authored-by: Drashna Jaelre <[email protected]>
nhongooi
pushed a commit
to nhongooi/qmk_firmware
that referenced
this pull request
Dec 5, 2021
Co-authored-by: Drashna Jaelre <[email protected]>
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
Co-authored-by: Drashna Jaelre <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Increased the size of the Lufa-MS bootloader to 8k
Reason stated here:
abcminiuser/lufa@5ada54b#diff-15ef1ada160ea767f8b2d21026d94de985fcc1641b8b83d69377053ccd6bfddf
The new version also fixed the issue of oversized firmware files overwriting parts of the bootloader and thus softbricking the MCU.
Writing oversized files to the flashdrive still works to an extent (it will show an error if the file is vastly oversized) but it just results in the keyboard not starting up. It can still be put back into bootloader mode afterwards without problems.
Throwing random files into the flash drive (like the MacOS typical .DS_Store) also doesn't hurt the bootloader anymore.
I guess we could remove the warning for the Lufa-MS bootloader now since it should be safe to use?
Relevant commit:
abcminiuser/lufa@ba6d9c1#diff-15ef1ada160ea767f8b2d21026d94de985fcc1641b8b83d69377053ccd6bfddf
Changes for the bootloader were tested on a dummy Arduino Pro Micro with the latest Lufa-MS bootloader.
Checklist