Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bop added via & unicode support #13122

Merged
merged 9 commits into from
Jun 24, 2021
Merged

Bop added via & unicode support #13122

merged 9 commits into from
Jun 24, 2021

Conversation

NathanBlais
Copy link

@NathanBlais NathanBlais commented Jun 6, 2021

Description

For the BOP board I added a VIA layout and added support for basic Unicode to that layout

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Added a VIA layout and added support for basic Unicode to that layout
@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jun 6, 2021
keyboards/bop/keymaps/via/rules.mk Outdated Show resolved Hide resolved
keyboards/bop/keymaps/via/rules.mk Outdated Show resolved Hide resolved
@NathanBlais
Copy link
Author

Thanks for the feedback, changes made

@blewis308
Copy link
Contributor

blewis308 commented Jun 16, 2021

Bumping for one more approval @fauxpark

keyboards/bop/keymaps/via/keymap.c Outdated Show resolved Hide resolved
@NathanBlais
Copy link
Author

@fauxpark changes have been made

@blewis308
Copy link
Contributor

@fauxpark any approval?

@NathanBlais
Copy link
Author

What do I need to do to get this merged?

@blewis308
Copy link
Contributor

What do I need to do to get this merged?

Click the Merge pull request below changes approved at the bottom

@NathanBlais
Copy link
Author

What do I need to do to get this merged?

Click the Merge pull request below changes approved at the bottom

I'm not authorized

@fauxpark fauxpark merged commit 61ec002 into qmk:master Jun 24, 2021
@fauxpark
Copy link
Member

Thanks!

sperly pushed a commit to sperly/qmk_firmware that referenced this pull request Jul 2, 2021
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>
jakeprime pushed a commit to jakeprime/qmk_firmware that referenced this pull request Jul 10, 2021
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Jul 11, 2021
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>
wox pushed a commit to wox/qmk_firmware that referenced this pull request Aug 14, 2021
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants