Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added another layer for VIA on the AEK II #13100

Merged
merged 6 commits into from
Jul 23, 2021
Merged

Added another layer for VIA on the AEK II #13100

merged 6 commits into from
Jul 23, 2021

Conversation

kb-elmo
Copy link
Contributor

@kb-elmo kb-elmo commented Jun 3, 2021

Description

Managed to squeeze another layer on the VIA keymap for my AEK II PCB

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jun 3, 2021
@kb-elmo
Delete ergomorph55.c
0643590 
accidental commit
@drashna
Copy link
Member

drashna commented Jun 7, 2021

May be worth adding #define LAYER_STATE_8BIT to the via config.h.

@kb-elmo
Copy link
Contributor Author

kb-elmo commented Jul 22, 2021

bump

@drashna drashna requested a review from a team July 22, 2021 18:42
@drashna
Copy link
Member

drashna commented Jul 23, 2021

Thanks!

@drashna drashna merged commit 4a8f540 into qmk:master Jul 23, 2021
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@kb-elmo @nhongooi
[Keyboard] Added another layer for VIA on the AEK II (qmk#13100)
9260ef7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kb-elmo @drashna @fauxpark