gBoards GergoPlex #13027

pirj · 2021-05-28T15:33:09Z

Description

Add firmware for gBoards GergoPlex.

Not done

SPLIT_KEYBOARD=yes could potentially reduce the amount of custom code
in the custom matrix code rows and cols seem to be mixed up. Might be it's intentional
the code is reading directly using PINF (inherited from gBoards GergoPlex #8928)

Types of Changes

Keyboard (addition or update)

Issues Fixed or Closed by This PR

fixes #8262, #8928, #10406

Checklist

My code follows the code style of this project: C, Python
I have read the PR Checklist document and have made the appropriate changes.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
I have tested the changes and verified that they work and don't break anything (as well as I can manage).

bttnns · 2021-05-28T16:06:38Z

Referencing this comment since the old PR seems broken.

#10406 (comment)
cloned pirj's branch, built, flashed and am running this latest update on my gergoplex, things seem OK - will update if something seems broken as I use the keyboard today

bttnns · 2021-05-28T16:30:10Z

EDIT: THIS IS FIXED ~~looks like everything works except the mouse functionality, neither clicking or moving seem to work (which you mentioned the lmb and rmb do not seem to work)~~

EDIT: THIS IS FIXED WITH pirj#2 not sure if you modified the delay on the hold modifiers for shift/ctrl or if its me due to not using the light key switches in little bit but typing 'what' seems to often result in 'hw' on osx since it registers wh ctrl+t. I personally think the hold delay is too short (not sure where to change it)

EDIT: not sure why this one does this, but this isn't a blocker imo... -> Also the HJKL combo seems like other combos are coming through (although to be honest, it might have done that before)

<:>I"D JUST LIKE TO INTERJECT FOR A MOMENT>
<:>I"D JUST LIKE TO INTERJECT FOR A MOMENT>
<:>I"D JUST LIKE TO INTERJECT FOR A MOMENT>
>:<I"D JUST LIKE TO INTERJECT FOR A MOMENT>
:<>I"D JUST LIKE TO INTERJECT FOR A MOMENT>
>:<I"D JUST LIKE TO INTERJECT FOR A MOMENT>
<:>I"D JUST LIKE TO INTERJECT FOR A MOMENT>

but based on the keymap it should be "I'd just like to interject for a moment." - not that I use that combo, but why doesn't this output what is in the keymap?

Just mostly noting things I think I noticed between flashing the original fw, but awesome work this is pretty usable! ~~other than the hold delay (but maybe as I warm up it will be fine)!~~

keyboards/gboards/gergoplex/keymaps/default/rules.mk

bttnns · 2021-05-28T17:45:18Z

pirj#1

updated the delay:

it was set to 40
docs seem to show 300
so went with 400
https://beta.docs.qmk.fm/using-qmk/software-features/feature_combo

also the mousekey_enable = no in the keymap seemed to override whats expected, so changed that to yes now the mouse seems to work.

seems much more usable with 400 vs 40!

still confused why the combo hjkl is all caps and the other combos come through too, but that doesn't really effect usability since multi-combo hj/jk/kl + hjkl is unlikely, but it would be nice to figure out

pirj · 2021-05-28T19:46:18Z

@btannous Incorporated your fixes with an adjustment - removed the redundant MOUSEKEY_ENABLE from keymaps/default/rules.mk so it falls back to rules.mk; removed the COMBO_TERM so it falls back to TAPPING_TERM that is 200 by default.
Thank you!

bttnns · 2021-05-28T20:39:29Z

@pirj awesome work. IGNORE_MOD_TAP_INTERRUPT seems to fix my issue with the CTRL/Shift modifiers, so sent you a PR for that one line.

I'm using your latest branch + that config change and so far this seems to work well. So 👍 in getting the gergoplex added to qmk!

pirj · 2021-05-28T21:06:55Z

@btannous Thanks, merged!
I am sorry for thoughtlessly removing this option.

bttnns · 2021-05-28T21:12:19Z

All good, that change makes a huge difference on those keys. Now Im hopeful this is good to the QMK maintainers! Thanks all :)

keyboards/gboards/gergoplex/gergoplex.c

keyboards/gboards/gergoplex/gergoplex.h

keyboards/gboards/gergoplex/keymaps/default/keymap.c

keyboards/gboards/gergoplex/matrix.c

keyboards/gboards/gergoplex/rules.mk

stale · 2021-07-16T11:42:13Z

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

Telltak · 2021-07-17T00:39:12Z

Is there anything I can do as an amateur with C to help with this? (waiting on my gergoplex to be shipped so no device yet)

ghost · 2021-07-25T18:18:17Z

~~I have not attempted to debug, but~~ merging manna-harbour/miryoku into this branch and make gboards/gergoplex:manna-harbour_miryoku builds without errors and is functional ~~but the keyboard is not functional after flashing.~~

edit: this does work. I just had to unplug/plug in my keyboard after flashing. this works with commit
64875d8 . thanks @caksoylar

caksoylar · 2021-07-25T22:47:51Z

@stjoni I believe the latest commit in the PR is still WIP with the custom matrix lite refactor. Commits up to and including 06b85ec builds and works fine on my end.

drashna · 2021-07-30T05:58:16Z

For now, it may be simplest/best to revert the matrix lite code.

pirj · 2021-07-30T08:12:58Z

@drashna Thank you! Will handle it over the weekend.
It was a slight improvement code-wise, but not as significant as I imagined it would be to reuse the commonly used code.

pirj · 2021-07-30T15:40:29Z

@drashna I've reset the commit with matrix lite.

keyboards/gboards/gergoplex/rules.mk

pirj · 2021-08-14T21:38:11Z

Rebased on develop.

| avr-gcc: error: .build/obj_gboards_gergoplex_default/quantum/debounce/eager_pr.o: No such file or directory

pirj · 2021-08-15T16:01:41Z

Silly me, I forgot to remove two commits related to custom matrix lite. Removed. Now everything works fine. 🎉

@btannous I've incorporated your changes for Colemak Mod-DH. I've kept germ-mouse-keys.def separate, just in case someone would want to exclude them, and it's as easy as editing their combos.def. Thanks!

Telltak · 2021-09-09T18:33:47Z

Is there anything we/I can do to help with this?

bttnns · 2021-09-11T03:12:08Z

bttnns · 2021-09-17T18:07:09Z

I'd just like to interject for a moment. Typing this on my georgoplex after

I checked out https://github.com/pirj/qmk_firmware/tree/prettify-gergoplex
merged with a freshly synced master
flashed with qmk on an m1 chip.

all works well. cant wait till this finally is going to get merged in. thanks everyone, should also note the hjkl combo works as expected now, so should be easy to add custom combos

pirj · 2021-09-21T21:20:33Z

Thank you, @germ, @btannous, @manna-harbour, dear maintainers, and early testers @yorickpeterse, @stjoni and @caksoylar for this to happen! 🎉

@germ

* Moved gergoplex to seperate PR * vendor + cformat * Update keyboards/gboards/k/gergoplex/matrix.c Co-Authored-By: Drashna Jaelre <[email protected]> * lifiting keyboards up * Update readme.md * Update keyboards/gboards/gergoplex/config.h Co-authored-by: Drashna Jaelre <[email protected]> * remove English dicts * cformatted * Prettify keymap * Remove via keymaps Via doesn't support chords/combos, and this makes the keymap on such a small keyboard quite uncomfortable and incomplete. * Address QMK pull code review notes * Cleanup (tabs, excessive comments) * Fix keymap typos * Use enum to define layers * Multiple changes - got rid of LAYOUT_kc in favour of LAYOUT_split_3x5_3 - fixed matrix custom C code to build with updated external dependencies (gcc) - fixed used combo docs keyboards/gboards/gergoplex/matrix.c:189:9: error: implicit declaration of function 'phex' [-Werror=implicit-function-declaration] phex(row); ^~~~ keyboards/gboards/gergoplex/matrix.c:191:9: error: implicit declaration of function 'pbin_reverse16'; did you mean 'print_bin_reverse16'? [-Werror=implicit-function-declaration] pbin_reverse16(matrix_get_row(row)); * Remove apparently redundant macros * Replace direct pin control with IO functions * config mouse enable and combo delay fix The default delay is 200: #define COMBO_TERM 200 how long for the Combo keys to be detected. Defaults to TAPPING_TERM if not defined. tmk_core/common/action_tapping.h|22| 13:# define TAPPING_TERM 200 * Remove redundant defines * Unambiguously refer to the Special layer * Fix formatting * gboards/gergoplex set IGNORE_MOD_TAP_INTERRUPT This solves my issue was with KC_CTL_A working correctly and it was set in @germ's repo https://github.com/germ/qmk_firmware/blob/39c86e080dc04b68ee08387dcb5144c88cb44855/keyboards/gboards/k/gergoplex/config.h#L49 https://beta.docs.qmk.fm/using-qmk/software-features/tap_hold#ignore-mod-tap-interrupt * Name change See commit 5813685 * Wording change * Update keyboards/gboards/gergoplex/keymaps/default/keymap.c Co-authored-by: Drashna Jaelre <[email protected]> * Add copyright headers * Fix debounce type | avr-gcc: error: .build/obj_gboards_gergoplex_default/quantum/debounce/eager_pr.o: No such file or directory * Implement colemak-dhm keymap Co-authored-by: Germ <[email protected]> Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: Brian Tannous <[email protected]>

@germ

* Moved gergoplex to seperate PR * vendor + cformat * Update keyboards/gboards/k/gergoplex/matrix.c Co-Authored-By: Drashna Jaelre <[email protected]> * lifiting keyboards up * Update readme.md * Update keyboards/gboards/gergoplex/config.h Co-authored-by: Drashna Jaelre <[email protected]> * remove English dicts * cformatted * Prettify keymap * Remove via keymaps Via doesn't support chords/combos, and this makes the keymap on such a small keyboard quite uncomfortable and incomplete. * Address QMK pull code review notes * Cleanup (tabs, excessive comments) * Fix keymap typos * Use enum to define layers * Multiple changes - got rid of LAYOUT_kc in favour of LAYOUT_split_3x5_3 - fixed matrix custom C code to build with updated external dependencies (gcc) - fixed used combo docs keyboards/gboards/gergoplex/matrix.c:189:9: error: implicit declaration of function 'phex' [-Werror=implicit-function-declaration] phex(row); ^~~~ keyboards/gboards/gergoplex/matrix.c:191:9: error: implicit declaration of function 'pbin_reverse16'; did you mean 'print_bin_reverse16'? [-Werror=implicit-function-declaration] pbin_reverse16(matrix_get_row(row)); * Remove apparently redundant macros * Replace direct pin control with IO functions * config mouse enable and combo delay fix The default delay is 200: #define COMBO_TERM 200 how long for the Combo keys to be detected. Defaults to TAPPING_TERM if not defined. tmk_core/common/action_tapping.h|22| 13:# define TAPPING_TERM 200 * Remove redundant defines * Unambiguously refer to the Special layer * Fix formatting * gboards/gergoplex set IGNORE_MOD_TAP_INTERRUPT This solves my issue was with KC_CTL_A working correctly and it was set in @germ's repo https://github.com/germ/qmk_firmware/blob/39c86e080dc04b68ee08387dcb5144c88cb44855/keyboards/gboards/k/gergoplex/config.h#L49 https://beta.docs.qmk.fm/using-qmk/software-features/tap_hold#ignore-mod-tap-interrupt * Name change See commit 5813685 * Wording change * Update keyboards/gboards/gergoplex/keymaps/default/keymap.c Co-authored-by: Drashna Jaelre <[email protected]> * Add copyright headers * Fix debounce type | avr-gcc: error: .build/obj_gboards_gergoplex_default/quantum/debounce/eager_pr.o: No such file or directory * Implement colemak-dhm keymap Co-authored-by: Germ <[email protected]> Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: Brian Tannous <[email protected]>

@germ

* Moved gergoplex to seperate PR * vendor + cformat * Update keyboards/gboards/k/gergoplex/matrix.c Co-Authored-By: Drashna Jaelre <[email protected]> * lifiting keyboards up * Update readme.md * Update keyboards/gboards/gergoplex/config.h Co-authored-by: Drashna Jaelre <[email protected]> * remove English dicts * cformatted * Prettify keymap * Remove via keymaps Via doesn't support chords/combos, and this makes the keymap on such a small keyboard quite uncomfortable and incomplete. * Address QMK pull code review notes * Cleanup (tabs, excessive comments) * Fix keymap typos * Use enum to define layers * Multiple changes - got rid of LAYOUT_kc in favour of LAYOUT_split_3x5_3 - fixed matrix custom C code to build with updated external dependencies (gcc) - fixed used combo docs keyboards/gboards/gergoplex/matrix.c:189:9: error: implicit declaration of function 'phex' [-Werror=implicit-function-declaration] phex(row); ^~~~ keyboards/gboards/gergoplex/matrix.c:191:9: error: implicit declaration of function 'pbin_reverse16'; did you mean 'print_bin_reverse16'? [-Werror=implicit-function-declaration] pbin_reverse16(matrix_get_row(row)); * Remove apparently redundant macros * Replace direct pin control with IO functions * config mouse enable and combo delay fix The default delay is 200: #define COMBO_TERM 200 how long for the Combo keys to be detected. Defaults to TAPPING_TERM if not defined. tmk_core/common/action_tapping.h|22| 13:# define TAPPING_TERM 200 * Remove redundant defines * Unambiguously refer to the Special layer * Fix formatting * gboards/gergoplex set IGNORE_MOD_TAP_INTERRUPT This solves my issue was with KC_CTL_A working correctly and it was set in @germ's repo https://github.com/germ/qmk_firmware/blob/39c86e080dc04b68ee08387dcb5144c88cb44855/keyboards/gboards/k/gergoplex/config.h#L49 https://beta.docs.qmk.fm/using-qmk/software-features/tap_hold#ignore-mod-tap-interrupt * Name change See commit 5813685 * Wording change * Update keyboards/gboards/gergoplex/keymaps/default/keymap.c Co-authored-by: Drashna Jaelre <[email protected]> * Add copyright headers * Fix debounce type | avr-gcc: error: .build/obj_gboards_gergoplex_default/quantum/debounce/eager_pr.o: No such file or directory * Implement colemak-dhm keymap Co-authored-by: Germ <[email protected]> Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: Brian Tannous <[email protected]>

commit d5fae3a6f96d44a432350d5f487204a962c5f9bc Author: Grayson Carr <[email protected]> Date: Wed Oct 6 11:36:04 2021 -0400 Updated Keychron Q1 user keymap (#14666) * Updated Keychron Q1 user keymap - Added Caps Lock indicator - Mission Control and Launchpad custom keycodes are now defined using the VIA user keycodes range so they can be labeled properly in VIA * Only use VIA keycode range if VIA is enabled * Reformatted led_indexes enum to match layout * Feature: When the Fn layer is active, RGB lighting turns off for keys that are not assigned * Fixes * Cleanup: Updated method signature of rgb_matrix_set_color_by_keycode to more closely match rgb_matrix_set_color * Fixed int sizing for keycodes commit f32db0bdd1f25099605ed324f1e8eab9aa7361e4 Author: James Young <[email protected]> Date: Wed Oct 6 08:44:57 2021 +0000 Mode M65S touch-up (#14722) * add Configurator data * rename README.md to lowercase API can't find this file unless the filename is lowercase (`readme.md`). * readme touch-up Correct typos and improve some grammar and Markdown. commit c33491d72b6a0da0b589c36200e983a150a0e415 Author: James Young <[email protected]> Date: Wed Oct 6 05:53:53 2021 +0000 MelGeek Mach80: correct Configurator layout (#14716) Adds a 0.5u gap between the top two rows. commit 4782e038d9de07aaead294579176c28b4e8451bc Author: remanifest <[email protected]> Date: Tue Oct 5 20:58:40 2021 -0500 Added semicolons to rules.mk to allow symlinks from /bin/sh to /bin/zsh to complete the filesize check without error. (#14718) Co-authored-by: John Beard <[email protected]> commit 3b8c4979dc17a52cd87f30b4986ca46d0b365860 Author: Drashna Jaelre <[email protected]> Date: Tue Oct 5 17:50:23 2021 -0700 [Bug] Fix command feature if mousekey is enabled and using 3-speed setting (#14697) commit 22470f030206336c970bc5f6e1d82f25520224f5 Author: Drashna Jaelre <[email protected]> Date: Tue Oct 5 17:49:39 2021 -0700 [Keyboard] Add basic Keyhive Sofle support (#14296) Co-authored-by: Ryan <[email protected]> Co-authored-by: Sergey Vlasov <[email protected]> commit e8db309613c99d1ffe25320680368d41bf5c8535 Author: MechMerlin <[email protected]> Date: Tue Oct 5 16:49:50 2021 -0700 [Keymap] Some updates to mechmerlin userspace and keymaps (#14711) commit e762db44bae46c631186c807a9c10fd8e4684535 Author: James Young <[email protected]> Date: Tue Oct 5 23:37:42 2021 +0000 0xc7/61key touch-up (#14712) * correct Configurator layout data * rename LAYOUT to LAYOUT_60_ansi * correct info.json maintainer field Use the maintainer's GitHub username. * correct the compiling/flashing instructions Keyboard value is relative to `qmk_firmware/keyboards/`. commit aabc0cc8ad44448ae56604e9edd5b40a8aaa3a0b Author: James Young <[email protected]> Date: Tue Oct 5 23:30:09 2021 +0000 Durgod DGK6X Galaxy: correct Configurator layout (#14714) Top row had a y-value of 1, which placed it behind the number row when rendered. commit 4676a14596f8ad4065acd2e18c892e0ee61ee346 Author: Nick Brassel <[email protected]> Date: Wed Oct 6 06:46:36 2021 +1100 More PR checklist updates (#14705) * Wording, clarification. * Apply suggestions from code review Co-authored-by: Mikkel Jeppesen <[email protected]> Co-authored-by: Mikkel Jeppesen <[email protected]> commit 7a49e5d2078e8e1044f11d0d7d2a67e82867024a Author: Nick Brassel <[email protected]> Date: Tue Oct 5 20:29:52 2021 +1100 Add clarification for licensing. (#14704) * Add clarification for licensing. * Errr, v2. commit 46fe8ab4e28182418a639b92490d6c5ca30897ef Author: Danny <[email protected]> Date: Mon Oct 4 23:38:24 2021 -0400 [Keyboard] Update Iris default keymap (#14701) commit 85ba5074825f608501e14594764cdc3c82a08c01 Author: Daniel Cormier <[email protected]> Date: Mon Oct 4 21:35:48 2021 -0400 [Keyboard] Added DC MC 001 (#14661) commit b441efbdf64d30031854c68a9c76376b38339b1e Author: moyi4681 <[email protected]> Date: Tue Oct 5 09:16:47 2021 +0800 [Keyboard] add dztech duo_s keyboard (#14625) Co-authored-by: Drashna Jaelre <[email protected]> commit 27d9579fd52b56dd4aa65e14a604ae4eb51386f3 Author: Albert Y <[email protected]> Date: Tue Oct 5 07:21:02 2021 +0800 Document examples on intercepting Mod-Tap (#14502) Co-authored-by: Ryan <[email protected]> Co-authored-by: Dasky <[email protected]> Co-authored-by: filterpaper <filterpaper@localhost> commit 20f81af98af26d3e15277e402a364a513f986aa6 Author: Zach White <[email protected]> Date: Mon Oct 4 09:26:19 2021 -0700 Allow community layouts to be specified in info.json (#14682) * move the community layout detection to python * fixup tests commit f72b2ad720b5b61a6e49b12a9375b97046ed5d8e Author: Danny <[email protected]> Date: Mon Oct 4 01:35:00 2021 -0400 [Keyboard] Add Iris Rev. 6 (#14683) Co-authored-by: Ryan <[email protected]> commit 6279399425c8893b586f68da06a719b94b48b4e2 Author: Drashna Jaelre <[email protected]> Date: Sun Oct 3 14:17:46 2021 -0700 [Keyboard] Fix Mechlovin's Olly/BB keyboard matrix file (#14680) commit 640869257f996b9f505e73f531b5343dc9124444 Author: Drashna Jaelre <[email protected]> Date: Sun Oct 3 14:17:23 2021 -0700 [Keyboard] Disable RGBLIGHT on mokey64 (#14681) commit 8782dc824d3d0ffddb087077ef94f728c18140db Author: tiltowait <[email protected]> Date: Sun Oct 3 12:02:51 2021 -0700 [Keyboard] Add anti-ghosting support to Model M Converter (#14049) commit 5ece2846b6a4d7ad82a26b2d68d0ec85705f5155 Author: Christian Sandven <[email protected]> Date: Sun Oct 3 21:01:15 2021 +0200 [Keyboard] Fix key routing for Keyprez Rhino ergo keys (#14589) commit 0acedbe09fb5e92fa5df722799aebc3edd9e2c8d Author: 4pplet <[email protected]> Date: Sat Oct 2 17:17:54 2021 +0200 [Keyboard] Adding kbnordic nordic60 (#14555) Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: Ryan <[email protected]> Co-authored-by: 4pplet <[email protected]> Co-authored-by: 4pplet <[email protected]> commit 875bbd31dc46d14a3a87d633081d1ba9c1225923 Author: ai03 <[email protected]> Date: Sun Oct 3 00:06:37 2021 +0900 [Keyboard] Add JP60 keyboard (#14219) Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: Ryan <[email protected]> commit 0eaefb2a6c35fdf15b067181529eacb7335fd562 Author: mechlovin <[email protected]> Date: Sat Oct 2 08:00:05 2021 -0700 [Keyboard] Add Olly BB PCB (#14545) Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: Ryan <[email protected]> commit 20a689e27cd84c1b80fc2db54bff5a4225cbf6bd Author: rhmokey <[email protected]> Date: Sat Oct 2 22:59:47 2021 +0800 [Keyboard] Modify mokey64 (#14612) Co-authored-by: Ryan <[email protected]> commit 79ad30a9d59c897b8aefb4dad755d74d9f32f15f Author: john-ezra <[email protected]> Date: Sat Oct 2 07:50:55 2021 -0700 [Keymap] Updates to Personal Kyria Keymap (#14669) Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: Ryan <[email protected]> commit 54b8d6a89182390533ccd1cb715fbaf59720bf3e Author: Drashna Jaelre <[email protected]> Date: Fri Oct 1 17:13:15 2021 -0700 [Keyboard] Convert ZSA's Moonlander keyboard to matrix lite (#14667) commit bed7625f93efab7be5461a1ca24e4a54f7b4202b Author: negatv <[email protected]> Date: Fri Oct 1 18:32:53 2021 -0400 Add FIRMWARE_FORMAT = hex for /keyboards/kinesis/kint36 and /keyboards/kinesis/kint41 (#14665) * Specify hex as the default FIRMWARE_FORMAT which is copied to qmk_firmware root folder * Specify hex as the default FIRMWARE_FORMAT which is copied to qmk_firmware root folder Co-authored-by: sadkins <[email protected]> commit e54a57d32a55609727ad9e9ca9c4954f9a727798 Author: umi <[email protected]> Date: Fri Oct 1 17:24:53 2021 +0900 [Docs] update Japanese translation of mod_tap.md (#13981) * update mod_tap.md translation * add id on config_options.md and update text based on comments commit 52cb19713b794be130563ac20923e8e70e83971e Author: Purdea Andrei <[email protected]> Date: Fri Oct 1 00:24:19 2021 +0300 Fix documentation for NO_HAPTIC_MOD and NO_HAPTIC_FN features. (#14180) commit 0be3cd3e2b8a7c5996f39166ab4a8afb986251ee Author: npspears <[email protected]> Date: Thu Sep 30 09:50:18 2021 -0500 Quark_LP- change MCU and RGB (#14650) commit 292b7b3835c5518cdb90bc7d5b1d3030292ddbf8 Author: James Young <[email protected]> Date: Thu Sep 30 14:48:36 2021 +0000 Remove firmware size impact notes from <keyboard>/rules.mk (#14652) commit 0b37e07f907cbb9654ecbc6449bb690f91f9ab20 Author: Ryan <[email protected]> Date: Thu Sep 30 19:17:20 2021 +1000 Remove redundant `MIDI_ENABLE = no` in keyboard-level rules.mk (#14649) commit a8e13f041e55fe46d7168eecf1c9862f22ef5f3e Author: James Young <[email protected]> Date: Thu Sep 30 08:20:46 2021 +0000 Mechlovin Hex4B: extend layout support (#14651) * use XXX for KC_NO in hex4b.h * add matrix diagram to hex4b.h * rename LAYOUT to LAYOUT_all * remove reference to KBFirmware JSON Parser * info.json: add line breaks between rows * rename LAYOUT_all to LAYOUT_split_bs - LAYOUT alias for backward compatibility - LAYOUT_all alias to signify support for every matrix position * add LAYOUT_2u_bs * add LAYOUT_tsangan_split_bs * add LAYOUT_tsangan_2u_bs * info.json: remove meta key commit 36bc3c867eda54921b64b2f4e7262a371dbecd65 Author: Ryan <[email protected]> Date: Thu Sep 30 08:14:21 2021 +1000 Remove redundant `UNICODE_ENABLE = no` in keyboard-level rules.mk (#14633) commit 8fccd82d4ec8292892067ab06dd235cf9b2d1565 Author: James Young <[email protected]> Date: Wed Sep 29 19:48:37 2021 +0000 Mechlovin Hannah60RGB touch-up (#14646) * use XXX for KC_NO in rev1.h * add matrix diagram to rev1.h * remove reference to KBFirmware JSON Parser from rev1.h * use XXX for KC_NO in rev2.h * add matrix diagram to rev2.h * add LAYOUT_60_ansi and LAYOUT_60_iso * enable Community Layout support * update info.json metadata - specify keyboard revision in keyboard_name - use GitHub username in maintainer field * remove reference to KBFirmware JSON Parser from main rules.mk commit 02ab7b1888e6572178543ca0b944e4fa14cdf974 Author: Drashna Jaelre <[email protected]> Date: Wed Sep 29 11:37:11 2021 -0700 [Core] Fix "6kro enable" and clarify naming (#14563) * Fix USB_6KRO_ENABLE compilation errors * Add info to docs * Rename define to be more accurate * Remove unused rule * Refixe docs commit 1e54796f0cf469e2c1fdd880cc288b04e7b83985 Author: Drashna Jaelre <[email protected]> Date: Wed Sep 29 11:16:11 2021 -0700 [Keymap] Update to Drashna Code (#14644) commit 929d959ef9e2572b4744930d86e322936e6e1f0e Author: npspears <[email protected]> Date: Wed Sep 29 11:55:58 2021 -0500 [Keyboard] add support for Quark_LP (#14552) Co-authored-by: Ryan <[email protected]> Co-authored-by: Drashna Jaelre <[email protected]> commit 03df75455126ecd395957bcbad48d19ca91fdbd5 Author: vattern <[email protected]> Date: Wed Sep 29 17:55:34 2021 +0100 [Keyboard] Update Grandiceps to Rev2 (#14618) Co-authored-by: Ryan <[email protected]> Co-authored-by: Dasky <[email protected]> Co-authored-by: Thys de Wet <[email protected]> commit c89f74b929721d01bf8177aa10c3cd721247a857 Author: jonavin <[email protected]> Date: Wed Sep 29 12:42:53 2021 -0400 [Keymap] Jonavin murphpad keymap update (#14637) Co-authored-by: Jonavin <=> commit 0338481090f4c2330a7fd237416cf66ba2bd4d22 Author: Drashna Jaelre <[email protected]> Date: Wed Sep 29 09:30:25 2021 -0700 [Keyboard] Updates for Tractyl Manuform config (#14641) commit 363eb645fc524efecc63b723a4b6d92fce29beaa Author: Drashna Jaelre <[email protected]> Date: Wed Sep 29 00:38:41 2021 -0700 [Keyboard] Fix end of file issue for Owlab suit80 (#14640) commit 046e3ce5c9291ca36d55e7407f765dee3a89462e Author: Grayson Carr <[email protected]> Date: Tue Sep 28 22:45:29 2021 -0400 [Keymap] Keychron Q1 user keymap (#14636) commit 02b760c6b0c72b8201a8a182654f0f277461a9d4 Author: James Young <[email protected]> Date: Tue Sep 28 23:02:48 2021 +0000 convert checkerboards/quark_squared:via rules.mk to Unix line endings (#14638) commit 732535c1bb381bbe93e9efc1cb1260bda67644a6 Author: James Young <[email protected]> Date: Tue Sep 28 21:49:35 2021 +0000 Mechlovin Delphine: add LAYOUT_numpad_6x4 (#14635) * add LAYOUT_numpad_6x4 * tidy-up info.json data * use GitHub account name for maintainer field * remove meta key * add matrix diagram to delphine.h * update Community Layout support commit 873a1999bb962834d88713796741c22339fb670f Author: Ryan <[email protected]> Date: Wed Sep 29 06:08:46 2021 +1000 Move "firmware size check skipped" note to message.mk (#14632) commit 705cd433c22aad00b12183eaa3bada50d90fd97b Author: jonavin <[email protected]> Date: Tue Sep 28 15:24:12 2021 -0400 [Keymap] fix NKRO - switch to get_mods() and refactor encoder action code (#14278) Co-authored-by: Jonavin <=> commit 724ee240751fdfedf33d75fee10d2b97d9f9e3da Author: Greg Knapp <[email protected]> Date: Tue Sep 28 20:23:38 2021 +0100 [Keyboard] Yampad VIA support (#14397) Co-authored-by: Drashna Jaelre <[email protected]> commit 4a2062cc0169785a6cd51a4a5de2bda8f0f78a40 Author: owlab-git <[email protected]> Date: Wed Sep 29 03:22:56 2021 +0800 [Keyboard] Add OwLab Suit80 (#14362) * add suit80 files * first add suit80 files * modified suit80 files * layout change * modified again * changed png url commit bc818352a309043b487ca2ad6b8e0ea10f8672b4 Author: Alexander Kagno <[email protected]> Date: Tue Sep 28 13:21:10 2021 -0600 [Keymap] arkag userspace/keymap -- new macro and minor preonic keymap change (#14623) Co-authored-by: Ryan <[email protected]> commit ac1d48cbf550322c88b51d6ade56eebfb46969fa Author: Harshit Goel <[email protected]> Date: Wed Sep 29 00:30:34 2021 +0530 [Keyboard] Pteron36 (#13475) Co-authored-by: Ryan <[email protected]> Co-authored-by: Harshti Goel <[email protected]> commit adc7cc5981561a537a2d83647bd84df3d4447ded Author: James Young <[email protected]> Date: Tue Sep 28 16:38:34 2021 +0000 Mechlovin Adelais: add support for full-length Right Shift (#14622) * add layout variants with 2.75u Right Shift * move layout alias to info.json * match info.json labels to matrix positions Edits the label keys in info.json to match the matrix position identifiers in adelais.h. * info.json: add line breaks between keyboard rows * info.json: use GitHub username in maintainer field commit 02451fcc7507128ea7bded71962e19df2b2ecb02 Author: Dasky <[email protected]> Date: Tue Sep 28 06:26:30 2021 +0100 [Keyboard] Add dz60rgb_ansi v2_1 (#14614) Co-authored-by: Ryan <[email protected]> commit 574b3d8a5a6891fff6d8058abc5c091f65f8dec2 Author: Sergi Meseguer <[email protected]> Date: Tue Sep 28 07:10:10 2021 +0200 [Keyboard] z12 micropad by zigotica (#14583) Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: Ryan <[email protected]> commit 2742d0c4c119c35980997ee43d9ce0fc412ec250 Author: peepeetee <[email protected]> Date: Tue Sep 28 13:00:47 2021 +0800 [Keyboard] Add BM80 Keyboard (#12948) * Initial compatibility with bm80 * move files to kprepublic directory, see #12159 * fix pin assignment * Revert "fix pin assignment" This reverts commit 5a53a74953a23bb5064c11d5d9e6daf007a54872. * add testing setup (peepeetee keymap, will use for personal purposes later), fix LED assignment, add indicator LED, LED location, count, and flags are broken * fixed flags( not sure, please check) * fixed number of LEDs * add comment about f11 * remove comment about f11, change capslock flag to be 1 rather than 1+8 as there is a standalone indicator LED * readme.md * add via keymap * add info.json with help from noroadsleft's converter * add suspended state implementation, I don't think it's working * update to my testing setup * restore erroneously included bm68rgb config * Update keyboards/kprepublic/bm80/config.h Co-authored-by: Drashna Jaelre <[email protected]> * add reset instructions * change reset instruction grammar * remove not working sleep function, add comment for RGB flags * add LED mapping comments * change readme grammar * replace rgb light paremeters with rgb matrix paremeters, enable framebuffer effects * re-enable peepeetee/config.h, updating my disabled effect list * updating my disabled effect list * update LED struct documentation * update readme with RGB matrix effect information * Update keyboards/kprepublic/bm80/rules.mk Co-authored-by: Drashna Jaelre <[email protected]> * move files back to keyboard from keyboard/kprepublic, see 85b33d6 and qmk#12159 * Apply suggestions from code review Co-authored-by: ridingqwerty <[email protected]> * cleanup peepeetee keymap * update peepeetee keymap; rebase on current master * moved to /kprepublic, see #12159 * Apply suggestions from code review Co-authored-by: Drashna Jaelre <[email protected]> * Apply suggestions from code review Co-authored-by: Ryan <[email protected]> Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: ridingqwerty <[email protected]> Co-authored-by: Ryan <[email protected]> commit ae993dc068b18f87174a8e313d84fcf88281147f Author: Ryan <[email protected]> Date: Tue Sep 28 03:50:06 2021 +1000 Zinc: Clean up LTO rules (#14597) commit e8b7cee9d321d24467fe408f2915cc69a44bcc4d Author: Ryan <[email protected]> Date: Tue Sep 28 03:46:10 2021 +1000 SquishyTKL: Layouts cleanup (#14594) commit fce9cb933845bf0b74d322eba02de3b76daaeb84 Author: Zach White <[email protected]> Date: Mon Sep 27 10:02:54 2021 -0700 Cleanup issues identified by lgtm (#14459) * cleanup issues identified by lgtm * fix the git_status check commit 5f38a98fa07677be960b71b8e3b0a1785effe0d8 Author: peott-fr <[email protected]> Date: Sun Sep 26 21:41:48 2021 -0700 Adding SP Mini keymap. (#14593) commit 3823fdc9e0a059040edb43e954dc2c9d3d3d8c45 Author: Drashna Jaelre <[email protected]> Date: Sun Sep 26 09:50:22 2021 -0700 [Keyboard] Fix Compile issues for Signum 3.0 (#14588) * [Keyboard] Fix Compile issues for Signum 3.0 * quantuuum commit f07de1b3094fbb94a70435c80b06b676db1f46b8 Author: Drashna Jaelre <[email protected]> Date: Sun Sep 26 07:54:17 2021 -0700 [Keyboard] Fix double comment in config files (#14615) commit 03f4c53564550024821aafadef69b5daaaa09abd Author: James Young <[email protected]> Date: Sun Sep 26 10:10:40 2021 +0000 Unicomp Mini M handwired Configurator fix (#14609) * apply human-friendly formatting * correct info.json data commit 6f36eb469d11fd9619add54c2e037e50069d1eee Author: James Young <[email protected]> Date: Sun Sep 26 09:57:20 2021 +0000 Remove unused `IS_COMMAND()` instances and Magic Key definitions (#14610) * Remove unused IS_COMMAND() instances from keyboard-level config.h, 0-9 * Remove unused IS_COMMAND() instances from keyboard-level config.h, A-B * Remove unused IS_COMMAND() instances from keyboard-level config.h, C-D * Remove unused IS_COMMAND() instances from keyboard-level config.h, E-G * Remove unused IS_COMMAND() instances from keyboard-level config.h, handwired * Remove unused IS_COMMAND() instances from keyboard-level config.h, H-M * Remove unused IS_COMMAND() instances from keyboard-level config.h, N-R * Remove unused IS_COMMAND() instances from keyboard-level config.h, S-Z * Remove unused Magic Key definitions from keyboard-level config.h, 0-9 * Remove unused Magic Key definitions from keyboard-level config.h, A * Remove unused Magic Key definitions from keyboard-level config.h, B * Remove unused Magic Key definitions from keyboard-level config.h, C * Remove unused Magic Key definitions from keyboard-level config.h, D-E * Remove unused Magic Key definitions from keyboard-level config.h, F-H * Remove unused Magic Key definitions from keyboard-level config.h, handwired * Remove unused Magic Key definitions from keyboard-level config.h, I-K * Remove unused Magic Key definitions from keyboard-level config.h, L-M * Remove unused Magic Key definitions from keyboard-level config.h, N-R * Remove unused Magic Key definitions from keyboard-level config.h, S-V * Remove unused Magic Key definitions from keyboard-level config.h, W-Z * Merge remote-tracking branch 'upstream/master' into clean/command_and_magic * Remove remaining unused IS_COMMAND() instances from keyboard-level config.h commit 95733d1c165e0f8af031cd79e58e9a49539647bb Author: James Young <[email protected]> Date: Sun Sep 26 07:01:11 2021 +0000 Remove references to KBFirmware JSON Parser (#14608) * remove refs: exclusive/e85/soldered * remove refs: handwired/bigmac * remove refs: handwired/boss566y/redragon_vara * remove refs: handwired/marauder * remove refs: id67 * remove refs: kprepublic/bm60rgb * remove refs: playkbtw/helen80 * remove refs: sam/sg81m * remove refs: sawnsprojects/satxri6key * remove refs: yncognito/batpad commit 14f0a417c7de9f71cf83723f4bb5852cdac03ab7 Author: James Young <[email protected]> Date: Sun Sep 26 05:48:14 2021 +0000 GG Keyboards Genesis: Layout Macro update and clean-up (#14606) * Genesis Hotswap: rename LAYOUT to LAYOUT_tkl_ansi * Genesis Hotswap: delete blank layers from default keymap Results in a smaller compiled firmware size. * Genesis Hotswap: tidy-up via keymap Fixes the visual alignment of keycodes. * Genesis Hotswap: specify Hotswap in info.json * Genesis Hotswap: enable Community Layout support * Genesis Hotswap: remove KBFirmware Parser references * Genesis Hotswap: specify Hotswap in config.h * Genesis Solder: correct keyboard layout * Genesis Solder: rename LAYOUT to LAYOUT_all I don't actually know with certainty that this *is* LAYOUT_all, but in the absence of more concrete information, I'm going with this. * Genesis Solder: delete blank layers from default keymap Results in a smaller compiled firmware size. * Genesis Solder: tidy-up via keymap Fixes the visual alignment of keycodes. * Genesis Solder: specify Hotswap in info.json * Genesis Solder: add LAYOUT_tkl_ansi * Genesis Solder: enable Community Layout support * Genesis Solder: remove KBFirmware Parser references * Genesis Solder: specify Solder in config.h commit 532cfd56ca47e5fdba2d759747dd4ac358e0af3a Author: James Young <[email protected]> Date: Sun Sep 26 05:22:04 2021 +0000 Exclusive E6 RGB Refactor (#14604) commit 8c76e1ec08390316127f9eeb076033a0e1ecf8b3 Author: James Young <[email protected]> Date: Sun Sep 26 04:53:57 2021 +0000 FLX Virgo: metadata clean-up (#14605) * correct maintainer field in info.json * remove KBFirmware Parser references commit 3296c26c9829ec261261a273130197235b05b05e Author: James Young <[email protected]> Date: Sat Sep 25 19:25:43 2021 +0000 Saka68 Solder Refactor (#14596) * rename LAYOUT to LAYOUT_68_ansi * tidy-up keymaps Adjusts indenting for readability/aesthetics. * add LAYOUT_68_iso macro * enable Community Layout support * add Split Backspace layout variants * remove KBFirmware Parser references * correct keyboard metadata commit 5c2d15573d32b839f0cf7915ef141812ab03bfdf Author: James Young <[email protected]> Date: Sat Sep 25 18:03:00 2021 +0000 Saka68 Hotswap Refactor (#14595) * rename LAYOUT to LAYOUT_68_ansi * tidy-up keymaps Adjusts indenting for readability/aesthetics. * remove default keymap readme * add LAYOUT_68_iso macro * enable Community Layout support * remove KBFirmware Parser references * correct keyboard metadata * specify keyboard variant in info.json and config.h * correct maintainer field in info.json commit aee0b0097b1a868fe63fe3be66c6c2947fcb3067 Author: Bahrul Hidayat <[email protected]> Date: Sun Sep 26 00:49:58 2021 +0800 [Keyboard] add keyboard dyz_TKL (#14535) Co-authored-by: Drashna Jaelre <[email protected]> commit 29079e54f140c5e1e9ef215cb16881e378bae2be Author: Bahrul Hidayat <[email protected]> Date: Sun Sep 26 00:49:26 2021 +0800 [Keyboard] add keyboard dyz40 (#14533) Co-authored-by: Drashna Jaelre <[email protected]> commit 8b0b858db957da74c77f737580f32009747ac8f1 Author: Bahrul Hidayat <[email protected]> Date: Sun Sep 26 00:48:47 2021 +0800 [Keyboard] add keyboard selka40 (#14560) Co-authored-by: Drashna Jaelre <[email protected]> commit c74bd72d4fde99a611e54bba18bdab4d2f24e038 Author: Albert Y <[email protected]> Date: Sun Sep 26 00:47:56 2021 +0800 [Keyboard] Fix pin spacing alignmnent (#14592) Co-authored-by: filterpaper <filterpaper@localhost> commit 68c327f6724347c06e0d62d6190945e09a42e240 Author: Ryan <[email protected]> Date: Sat Sep 25 18:31:24 2021 +1000 Remove keyboard-level `COMBO_ENABLE` rules (#14550) commit 3be47b3eaa7e18c49872d778d966a27de73004a5 Author: Drashna Jaelre <[email protected]> Date: Fri Sep 24 16:29:47 2021 -0700 [Keyboard] Fix default keymap for Potato65s (#14587) commit 216620ee769a97179074d8297998d9ea914f0c4e Author: James Young <[email protected]> Date: Fri Sep 24 23:29:08 2021 +0000 tidy up Clawsome Boards info.json files (#14586) * removes `meta` field * changes `maintainer` field to use GitHub username commit 9e87b47a9cc0e560258009bc2448dc3e43c369b5 Author: James Young <[email protected]> Date: Fri Sep 24 23:28:25 2021 +0000 Aozora Hotswap info.json clean-up (#14585) * clean up info.json * correct maintainer field to use GitHub username * remove `meta` key * clean up readme.md * correct key count in intro paragraph commit 4493a05b74d8852222faa776d140233745114c53 Author: Stan Gurenkov <[email protected]> Date: Fri Sep 24 13:05:29 2021 -0400 [Keyboard] refactor signum30 (#14527) Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: Ryan <[email protected]> Co-authored-by: Stan Gurenkov <[email protected]> commit 60b13d04cdf4b27f387be90d830dd196c38b1362 Author: James Young <[email protected]> Date: Fri Sep 24 16:29:58 2021 +0000 Alf X2 Refactor (#14572) commit 076a332613229110bb39d572f5b342306d380a74 Author: James Young <[email protected]> Date: Fri Sep 24 16:29:46 2021 +0000 Swift65 Solder Refactor (#14579) commit 3778dd5727e2ba468e559bc949b0f74827fe1a97 Author: WiZ.GG <[email protected]> Date: Fri Sep 24 19:59:18 2021 +0330 [Keyboard] add 2 keys in jkb65 keymap (#14576) commit 863d9c35feb583356c92aaa04c1b0f234febabc1 Author: Andrew Braini <[email protected]> Date: Fri Sep 24 12:27:29 2021 -0400 [Keyboard] Create the battleship gamepad keyboard. (#14551) Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: Ryan <[email protected]> commit 257bc473e5483b1411bb5015ccbbaadd08e6ff24 Author: Aeonstrife <[email protected]> Date: Fri Sep 24 21:43:53 2021 +0530 [Keyboard] Add Potato65 Solderable PCB (#14047) Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: Ryan <[email protected]> commit 768803ef727b3436a057257d83234809ed0e444f Author: Nick Abe <[email protected]> Date: Sat Sep 25 00:57:08 2021 +0900 [Keyboard] PLX info.json update (#14536) Co-authored-by: Ryan <[email protected]> commit 2d079c984f9dbf73124d1a07f530d2b2dca44932 Author: Nick Abe <[email protected]> Date: Sat Sep 25 00:56:37 2021 +0900 [Keyboard] Add Rotor Keyboard (#14407) * rotor keyboard * readme image * info.json update * Update readme.md * Update keyboards/rotor/rules.mk Co-authored-by: Ryan <[email protected]> * Update keyboards/rotor/info.json Co-authored-by: Ryan <[email protected]> Co-authored-by: Ryan <[email protected]> commit 4f37084677d7868362809bdd7df44d44efab2b67 Author: clickclackwho <[email protected]> Date: Fri Sep 24 08:43:05 2021 -0700 [Docs] Broken FAQ hyperlink (#14578) commit 77bb907feeb17f5a97544276d8a2e1b9cb512038 Author: Albert Engelbrecht <[email protected]> Date: Fri Sep 24 02:30:52 2021 -0500 [Keyboard] Added A. Dux keyboard configurations (#14320) Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: Ryan <[email protected]> commit c6f92e37aad673e9f6bc7694d5f8829bbb8b87de Author: phrygiandesign <[email protected]> Date: Fri Sep 24 17:25:33 2021 +1000 [Keyboard] Add phrygian design ph100 (#13738) Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: Ryan <[email protected]> commit c242693ec7c1f99b51026fc6870de6d949054713 Author: ryanbughuang <[email protected]> Date: Fri Sep 24 14:41:05 2021 +0800 [Keyboard] Add sam/sg81m layout (#13432) Co-authored-by: Joel Challis <[email protected]> commit e36c2cbf900c1232750e742ebf9ce365c747fc16 Author: Albert Y <[email protected]> Date: Fri Sep 24 14:32:40 2021 +0800 [Keyboard] Disable console on Sofle for size concerns (#14577) Co-authored-by: filterpaper <filterpaper@localhost> commit 30140f48d0968460fff7ef15994b616ee10e3d3f Author: umi <[email protected]> Date: Fri Sep 24 14:51:34 2021 +0900 [Docs] update Japanese translation of pr_checklist.md (#13693) * update pr_checklist.md translation * update file based on comments * add id on feature_led_indicators.md and update text based on comments * update file based on comments * update file based on comment commit f4e42bde4a9c8671b1263c356615a1762a2790ab Author: Sets3n <[email protected]> Date: Fri Sep 24 03:16:20 2021 +0800 kk980 - Fix Configurator rendering (#14556) * add kk980 * fix * fix config.h * Modified readme.md * fix * Modified format. * Modified image. * Modified rules.mk * Modified rules.mk + # * fix info.json: keys dislocation commit a68c4d8b8150d936b700a4d1f2f9670f97b78b87 Author: Drashna Jaelre <[email protected]> Date: Thu Sep 23 12:08:23 2021 -0700 [Keyboard] Update default keymaps for OLKB boards (#14565) commit 29f199f456e4ef364926d0d5babd96b708393955 Author: James Young <[email protected]> Date: Thu Sep 23 18:01:49 2021 +0000 AMJ96 Refactor (#14571) * clean up amj96.h - use #pragma once include guard - remove extra comments - update matrix position alignment (easier readability) * info.json: apply human-friendly formatting * rename LAYOUT to LAYOUT_all * clean up rules.mk Align to QMK's AVR template. * clean up default keymap - use four-space indent - add RESET keycode (Fn+R) - remove unnecessary functions * clean up config.h - use #pragma once include guard - move lighting settings to the middle of the file (QMK template conformance) - remove Magic and MIDI configuration blocks * update readme.md file - update keyboard info list - add flashing instructions - update Docs links - remove trailing spaces * remove "empty" config.h and readme.md from default keymap commit 66857b919beccfc9d3395ffe1f88cb39e044aca3 Author: James Young <[email protected]> Date: Thu Sep 23 08:31:11 2021 +0000 Wuque Mammoth20x Layout Macro Refactor (#14568) * mammoth20x: edit size of RightEncode key in Configurator * physically arrange layout macro Arranges the keycodes to resemble the assembled board. * rename LAYOUT_default to LAYOUT Includes "layout_aliases" tree in info.json for backwards compatibility. * rules.mk touch-up * convert tabs to spaces * add line break before ENCODER_ENABLE (not included in QMK's template) * readme.md touch-up * remove zero-width space characters * markdown fix for info paragraph * update link text commit 62ef4a9c8a05d52000504eabef0f1d92a74ade86 Author: James Young <[email protected]> Date: Thu Sep 23 07:49:02 2021 +0000 Meira Refactor (#14566) * clean up keyboard header files * use #pragma once include guard * convert tabs to spaces * remove redundant #include statements * update revision references to main header (`../meira.h` -> `meira.h`) * refactor default keymap * use LAYOUT as layout macro reference * use enum statement for layer indexes; make layers contiguous * use four-space indent * update keycode grid alignment * update layout macro aliases * move layout macro aliases to info.json * alias KEYMAP to LAYOUT_ortho_4x12 so the user keymaps don't have to be edited * touch up meira.h There's no Planck MIT layout reference here. * add copyright headers * workaround patch for grahampheath keymap The `matrix_init_kb()` function in `meira.c` calls `backlight_set()`, but the grahampheath keymap disables Backlight to make space for Audio, causing the firmware to fail to compile. This commit wraps the `backlight_set()` call in an ifdef statement, so the call is excluded if Backlight is disabled. * clean up rules.mk inline comments * re-order rules.mk settings * clean up readme.md * correct link to keyboard image * change metadata section to unordered list * spelling corrections * update make instructions and Docs links commit 0fc15f4d30311402bb6dbf74806a0c5ed00cb135 Author: umi <[email protected]> Date: Thu Sep 23 13:02:32 2021 +0900 [Docs] update Japanese translation of feature_backlight.md (#14403) * update feature_backlight.md translation * update file based on comments commit 7f0c397c72a3e4ba68e3b5c1a28cd57b7b0ad6f1 Author: umi <[email protected]> Date: Thu Sep 23 13:01:42 2021 +0900 [Docs] update Japanese translation of feature_advanced_keycodes.md (#14309) * update feature_advanced_keycodes.md translation * update file based on comments commit 53475773461c3a76ee253d99efef2a693fa1fca3 Author: umi <[email protected]> Date: Thu Sep 23 12:58:56 2021 +0900 [Docs] update Japanese translation of isp_flashing_guide.md (#13700) * update isp_flashing_guide.md translation * update isp_flashing_guide.md translation * correct url * trim remaining merge identifier commit 7bfc6083b75ec148c98487bece596f6e12c17e2c Author: umi <[email protected]> Date: Thu Sep 23 12:55:19 2021 +0900 [Docs] update Japanese translation of feature_leader_key.md (#13669) * update feature_leader_key.md translation * update file based on comments * update text based on comments commit 618a28c6ae382e84fcf4b40e3247153086c12e43 Author: umi <[email protected]> Date: Thu Sep 23 12:52:53 2021 +0900 [Docs] update Japanese translation of one_shot_keys.md (#13656) * update one_shot_keys.md translation * update one_shot_keys.md translation * correct paramter for function * add change of #13754 commit 4062860c053ca275a155f62db4680205c0bfb3da Author: drhigsby <[email protected]> Date: Wed Sep 22 18:02:49 2021 -0700 [Keyboard] Bkf (#14534) Co-authored-by: Ryan <[email protected]> commit 1aaef6c9884822a3abecf2e664af9bb21e0000c3 Author: James Young <[email protected]> Date: Wed Sep 22 19:33:41 2021 +0000 Remove BLUETOOTH_ENABLE from keyboard-level rules.mk (2021-09-22) (#14567) * Remove BLUETOOTH_ENABLE from keyboard-level rules.mk (2021-09-22) * update keyboards/handwired/slash/rules.mk per fauxpark commit ce5bb612a9605dbc9f4b6e62a28d1931331e8298 Author: Drashna Jaelre <[email protected]> Date: Wed Sep 22 09:53:03 2021 -0700 [Keyboard] Fix default keymap for Draytronics Elise V2 keyboard (#14562) commit 57d4e80845781af4387bbcc30784e163ea15617e Author: Drashna Jaelre <[email protected]> Date: Wed Sep 22 09:47:56 2021 -0700 [Keyboard] Disable console on Smallkeyboard (#14561) commit 01b0eeac1ebbf45ef974152f240b3132470d0da6 Author: Blake <[email protected]> Date: Wed Sep 22 07:49:46 2021 +0100 [Keyboard] Version 2 of Draytronics Elise Keyboard + ISO Keymap Change (#14253) Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: Ryan <[email protected]> commit c78a057ec4f3da9487f5fcce29a35785c930e17c Author: Sets3n <[email protected]> Date: Wed Sep 22 14:38:07 2021 +0800 [Keyboard] add kk980 keyboard (#14436) commit 5ddbabfa2a8ee7ce75dcbc30397eb5d588f9e51d Author: Drashna Jaelre <[email protected]> Date: Tue Sep 21 22:51:54 2021 -0700 [Keyboard] Fix jkb65 compile issues (#14554) commit ea5735b0741764acab905e1137dab9de1e3cf5a6 Author: Drashna Jaelre <[email protected]> Date: Tue Sep 21 22:39:19 2021 -0700 [Keyboard] Fix font file for Ein 60 Keyboard (#14553) commit 9c564b6a5fc249af397e1c1b0ec237a2629072e8 Author: Brandon Claveria <[email protected]> Date: Tue Sep 21 21:25:59 2021 -0700 [Keyboard] Add Dango40 (#14437) Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: Swiftrax <[email protected]> Co-authored-by: Swiftrax <[email protected]> commit c8a3353003bbe706258adc0a4a859b5c2c987cd3 Author: Caleb Lightfoot <[email protected]> Date: Tue Sep 21 23:24:44 2021 -0500 [Keyboard] Add Free Willy Keyboard (#14394) Co-authored-by: Ryan <[email protected]> commit 02556b3d8adcca4301ba88762e30244accbc0327 Author: Vinam Arora <[email protected]> Date: Wed Sep 22 09:54:14 2021 +0530 [Keyboard] 0-Sixty: Splits kb config into base and underglow (#14384) Co-authored-by: Drashna Jaelre <[email protected]> commit 4e0125c22c0271cbb5689eb501e60721706bedcb Author: kopibeng <[email protected]> Date: Wed Sep 22 12:23:51 2021 +0800 [Keyboard] Add support for XT8x (#14440) Co-authored-by: Drashna Jaelre <[email protected]> commit f37af05f2ac00689aa14492705eafa9f689fec41 Author: milostatsea <[email protected]> Date: Wed Sep 22 06:22:04 2021 +0200 [Keyboard] fixed one of the unicode drawings of the layout in dz60.h (#14482) commit 88f6776216abca69529f470982e70f36beb560b3 Author: WiZ.GG <[email protected]> Date: Wed Sep 22 07:51:44 2021 +0330 [Keyboard] Add JadooKB JKB65 RGB (#14525) Co-authored-by: Ryan <[email protected]> Co-authored-by: Drashna Jaelre <[email protected]> commit e0022daf116a480a8884e549b1fef2fc4c604234 Author: Pylon <[email protected]> Date: Wed Sep 22 00:21:23 2021 -0400 Changed VENDOR_ID and PRODUCT_ID of Boston keyboard (#14528) commit 88283cdab8be24000698b7a942725c591581cf8f Author: precondition <[email protected]> Date: Wed Sep 22 06:19:50 2021 +0200 [Keyboard] Add commented out OLED/encoder code in default Kyria (#14539) Co-authored-by: Dasky <[email protected]> Co-authored-by: Drashna Jaelre <[email protected]> commit 43e88f34aa2587b16ca3f344ae7c40e2dcb5b622 Author: James Smith <[email protected]> Date: Wed Sep 22 00:18:25 2021 -0400 [Keyboard] add ein_60 (#14398) Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: Ryan <[email protected]> commit 208ea0e18cc6725c173e106a88528fb0576f3ce6 Author: Drashna Jaelre <[email protected]> Date: Tue Sep 21 21:16:19 2021 -0700 [Keyboard] smallkeyboard fix of rgb matrix config (#14548) commit 033a318bdfafa8f90fc259e91bbebf10bc6bc7ca Author: Salicylic-acid3 <[email protected]> Date: Wed Sep 22 09:12:57 2021 +0900 [Keyboard] Addition of VIA keymap and a few fixes for naked48 (#14177) Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: Ryan <[email protected]> commit 45f88af4a12938072f58d89769145c46a30fb38c Author: Dasky <[email protected]> Date: Wed Sep 22 00:40:19 2021 +0100 [Docs] update suspend_*_user examples (#14542) commit bb754069e95237bec69cc23845e2515eea5f33e4 Author: zhouqiong19840119 <[email protected]> Date: Wed Sep 22 06:52:39 2021 +0800 [Keyboard] smallkeyboard support (#12817) Co-authored-by: Ryan <[email protected]> Co-authored-by: James Young <[email protected]> Co-authored-by: Drashna Jaelre <[email protected]> commit 32a96be09321870e7d7d084c893dee599e47132b Author: Laneware <[email protected]> Date: Wed Sep 22 08:06:56 2021 +1000 [Keyboard] Macro-1 keyboard by Laneware Peripherals (#14472) commit 922fbea5589b320ff57ca261f402bb9e63325496 Author: bt66tech <[email protected]> Date: Wed Sep 22 04:45:26 2021 +0700 [Keyboard] add via keymap support for bt66tech/bt66tech60 (#13818) Co-authored-by: root <[email protected]> commit be273bd0032d09b622368be22a3c99df63cecf37 Author: qpockets <[email protected]> Date: Tue Sep 21 17:16:16 2021 -0400 [Keyboard] add wanten keyboard to QMK (#14410) Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: Ryan <[email protected]> commit bd0040068e28b6df20693df2453591fc8f3f073a Author: kopibeng <[email protected]> Date: Wed Sep 22 05:15:09 2021 +0800 [Keyboard] Add support for MNK88 (#14435) Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: Ryan <[email protected]> commit cebc5688a09ce0fb9a6163dcea9155041ba89d5c Author: 3araht <[email protected]> Date: Wed Sep 22 06:13:36 2021 +0900 [Keyboard] add bandominedoni keyboard (#13116) commit c8a58691146495e5506a355d6fb6d65edbc78e79 Author: qpockets <[email protected]> Date: Tue Sep 21 17:12:55 2021 -0400 [Keyboard] add synapse pcb (#14428) Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: Ryan <[email protected]> commit 376968ade4e102f7a526252599755af4c16dd525 Author: Purdea Andrei <[email protected]> Date: Wed Sep 22 00:09:01 2021 +0300 [Keyboard] Add 5 boards by the OverNumpad Controller (#14382) * Add initial implementation of 5 keyboards supported by the OverNumpad Controller. * Apply suggestions from code review Co-authored-by: Drashna Jaelre <[email protected]> * Apply changes similar to other code review suggestions. * Apply suggestions from code review Co-authored-by: Drashna Jaelre <[email protected]> * Apply changes similar to other code review suggestions. * overnumpad controller info.jsons: update maintainer and url. * classic_ultracl_pre_2013: added support for the default 'fullsize_ansi' layout * classic_ultracl_pre_2013: moved the order of the iso enter key in the layout macro to be considered to be on the bottom row, like in the default fullsize_iso layout. Rename the iso layout to fullsize_iso, and enable it in rules.mk * Removed QMKBEST and QMKURL * Apply suggestions from code review Co-authored-by: Ryan <[email protected]> * Deleting empty files Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: Ryan <[email protected]> commit 8d32ddd8e948136a992ab3c10d13c7dbf9e1e119 Author: Phil Pirozhkov <[email protected]> Date: Wed Sep 22 00:07:55 2021 +0300 [Keyboard] gBoards GergoPlex (#13027) * Moved gergoplex to seperate PR * vendor + cformat * Update keyboards/gboards/k/gergoplex/matrix.c Co-Authored-By: Drashna Jaelre <[email protected]> * lifiting keyboards up * Update readme.md * Update keyboards/gboards/gergoplex/config.h Co-authored-by: Drashna Jaelre <[email protected]> * remove English dicts * cformatted * Prettify keymap * Remove via keymaps Via doesn't support chords/combos, and this makes the keymap on such a small keyboard quite uncomfortable and incomplete. * Address QMK pull code review notes * Cleanup (tabs, excessive comments) * Fix keymap typos * Use enum to define layers * Multiple changes - got rid of LAYOUT_kc in favour of LAYOUT_split_3x5_3 - fixed matrix custom C code to build with updated external dependencies (gcc) - fixed used combo docs keyboards/gboards/gergoplex/matrix.c:189:9: error: implicit declaration of function 'phex' [-Werror=implicit-function-declaration] phex(row); ^~~~ keyboards/gboards/gergoplex/matrix.c:191:9: error: implicit declaration of function 'pbin_reverse16'; did you mean 'print_bin_reverse16'? [-Werror=implicit-function-declaration] pbin_reverse16(matrix_get_row(row)); * Remove apparently redundant macros * Replace direct pin control with IO functions * config mouse enable and combo delay fix The default delay is 200: #define COMBO_TERM 200 how long for the Combo keys to be detected. Defaults to TAPPING_TERM if not defined. tmk_core/common/action_tapping.h|22| 13:# define TAPPING_TERM 200 * Remove redundant defines * Unambiguously refer to the Special layer * Fix formatting * gboards/gergoplex set IGNORE_MOD_TAP_INTERRUPT This solves my issue was with KC_CTL_A working correctly and it was set in @germ's repo https://github.com/germ/qmk_firmware/blob/39c86e080dc04b68ee08387dcb5144c88cb44855/keyboards/gboards/k/gergoplex/config.h#L49 https://beta.docs.qmk.fm/using-qmk/software-features/tap_hold#ignore-mod-tap-interrupt * Name change See commit 581368596ed * Wording change * Update keyboards/gboards/gergoplex/keymaps/default/keymap.c Co-authored-by: Drashna Jaelre <[email protected]> * Add copyright headers * Fix debounce type | avr-gcc: error: .build/obj_gboards_gergoplex_default/quantum/debounce/eager_pr.o: No such file or directory * Implement colemak-dhm keymap Co-authored-by: Germ <[email protected]> Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: Brian Tannous <[email protected]> commit d84794b35213fe95a712468c21ae4a4cad2795e3 Author: Ryan <[email protected]> Date: Wed Sep 22 02:54:36 2021 +1000 Remove keyboard-level `TAP_DANCE_ENABLE` rules (#14538) commit be3259b793a1fe4f42c20707e187371dd917a18f Author: Ryan <[email protected]> Date: Wed Sep 22 02:21:10 2021 +1000 Remove outputselect.h include from BIOI code (#14543) commit 19e33b685fe6ca05bc1c986a272c790ea0cdba45 Author: Dasky <[email protected]> Date: Tue Sep 21 15:52:57 2021 +0100 [Docs] Modify encoder_update_user example to return false (#14541) commit 6b74e48f81fd22f4b982c686df9c8d1f8efae571 Author: Ryan <[email protected]> Date: Tue Sep 21 20:04:03 2021 +1000 Remove audio pin references in rules.mk (#14532) commit 574b6734afb6ec7073f6fb816dd454f03b7eb26f Author: Ryan <[email protected]> Date: Mon Sep 20 16:51:00 2021 +1000 Remove backlight pin references in rules.mk (#14513) commit e25d37454c9c228003651ba5eeae468930ae572d Author: Ben Lipson <[email protected]> Date: Sun Sep 19 15:23:40 2021 -0500 [Keymap] blipson corne keymap (#14469) revert lib/chibios revert lib/chibios Finish up remove files Update copyrights remove copyrights readd copyrights add stop macro PR suggestions PR suggestions readme lowercase fix rotate for oled Co-authored-by: Z003YW4 <[email protected]> commit 4dbeeaa0d685ee7449010d2dc2a930a5921c8a8c Author: XScorpion2 <[email protected]> Date: Sun Sep 19 15:18:32 2021 -0500 Doc Fixes & Custom Matrix Fix (#14526) commit 121ca7eca9a53727733645d9c4c90a206df02258 Author: im a can what do you think lmao? <[email protected]> Date: Sun Sep 19 14:54:40 2021 -0400 [Keyboard] Add LeFishe Keyboard (#14498) Co-authored-by: Ryan <[email protected]> commit a068b14686507f67c7f0956d3367510bd9041641 Author: Jakob Weickmann <[email protected]> Date: Sun Sep 19 20:53:47 2021 +0200 [Keymap] Added my own keymap for MIT Planck (#14481) Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: Ryan <[email protected]> commit ddb6821b97c6d276e4190f98f49a4ee164fd0477 Author: David Xia <[email protected]> Date: Sun Sep 19 14:53:22 2021 -0400 [Docs] fix wrong directory for RGB Matrix animations (#14494) commit 53c2f677481f8531adc755e7f2c4163c6eb006b8 Author: James Young <[email protected]> Date: Sun Sep 19 18:52:54 2021 +0000 cKeys theDora Refactor (#14495) commit 4e7801d4fbcdf571bc7a73d5f5234321480affb0 Author: peott-fr <[email protected]> Date: Sun Sep 19 11:52:37 2021 -0700 [Keymap] Adding my Mun keymap. (#14501) commit 4348e2ffc11533a384d0eea452c954e57fe7e44c Author: Konstantin Đorđević <[email protected]> Date: Sun Sep 19 20:47:40 2021 +0200 [Keymap] Updates to existing keymaps and userspace (#14503) Co-authored-by: Drashna Jaelre <[email protected]> commit e83fb69ae8a579648a6a73e00399d3d144e51f88 Author: Pylon <[email protected]> Date: Sun Sep 19 14:47:13 2021 -0400 [Keyboard] Enabled Mousekeys by default on Boston (#14507) commit 5dbde91bdf5be6d14fd99842b9a2952d0589b84d Author: Dasky <[email protected]> Date: Sun Sep 19 19:45:11 2021 +0100 [Keyboard] Change printf to dprintf (#14510) commit fa5d21a58ebfe9782225c857ad2e533a0f65d161 Author: Jack Humbert <[email protected]> Date: Sun Sep 19 14:43:37 2021 -0400 [Keyboard] Enables I2C for OLKB rev*_drop boards (#14514) Co-authored-by: daskygit <[email protected]> commit 0e34efd9a2dd401a7cd38f552f7247b8afcb65fc Author: XScorpion2 <[email protected]> Date: Sun Sep 19 13:31:17 2021 -0500 [Keyboard] Quick fixes for the Mun to unblock customers (#14505) commit d9ca201f79dce27de667c638ed6404bd4d10146a Author: Drashna Jaelre <[email protected]> Date: Sun Sep 19 07:01:02 2021 -0700 [Keyboard] Fix Compiler issues for quick17 (#14500) commit ef5c6ea096033423c9b9e141c1fc94dcc41d84fa Author: Drashna Jaelre <[email protected]> Date: Sat Sep 18 20:10:32 2021 -0700 [Keyboard] Use old custom matrix for Drop Planck+Preonic (#14488) Co-authored-by: Ryan <[email protected]> Co-authored-by: Jack Humbert <[email protected]> commit f61f79b7cd1cb8edad8d55577c834a9470405b4c Author: Ramya Challa <[email protected]> Date: Sat Sep 18 12:47:26 2021 -0700 [Keyboard] Add Gentleman65 (#12971) Co-authored-by: Drashna Jaelre <[email protected]> commit c2f3c418f33bf5d8d60e005de4d076949a7c7098 Author: MakotoKurauchi <[email protected]> Date: Sun Sep 19 04:28:41 2021 +0900 [Keyboard] Add new keyboard quick17 (#13703) Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: Ryan <[email protected]> Co-authored-by: keyaki-namiki <[email protected]> commit e3e58aae6aaf4eb5f5a26c46dcc3d249cffb1a5f Author: kaylanm <[email protected]> Date: Sat Sep 18 15:27:49 2021 -0400 [Keyboard] Add superuser keyboard (#13840) Co-authored-by: Ryan <[email protected]> commit 23c3b9decb22e2a5aced2b8d487684370d42fa6d Author: Bahrul Hidayat <[email protected]> Date: Sun Sep 19 03:26:46 2021 +0800 [Keyboard] Add dyz60 (#13864) Co-authored-by: Ryan <[email protected]> commit 4e7133e262acf185fd4dc77a0cfad0083a88fae6 Author: Elliot Powell <[email protected]> Date: Sat Sep 18 19:39:58 2021 +0100 [Keyboard] Add support for Coarse60 (#14416) Co-authored-by: Joel Challis <[email protected]> Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: Ryan <[email protected]> commit 2c4660e40d7897c60e7f0718f25f866e33137334 Author: Lui Wolff <[email protected]> Date: Sat Sep 18 16:06:46 2021 +0000 [Keymap] Added Brazilian keymap for BM40RGB (#14431) commit c681c1a6a84a378ecc6c04174aafadd5f3d1b31f Author: Drashna Jaelre <[email protected]> Date: Sat Sep 18 00:53:16 2021 -0700 [Keyboard] Fix dosa40rgb compilation issues (#14491) commit d51bb76ec96c35f3b5494f8dd0ecb2611dccd3df Author: Jordan Duabe <[email protected]> Date: Sat Sep 18 14:52:53 2021 +0800 [Keymap] Add 'j4ckofalltrades' keymap for sofle/rev1 (#14446) commit 09b66c06d4fa0f2db1340e9f9b89ab27235bb500 Author: Dao Tak Isaac <[email protected]> Date: Sat Sep 18 13:52:18 2021 +0700 [Keyboard] Add Dosa40RGB + dtisaac01 (#14476) commit 228c7b095b0f441652b2719713cb3bf1e5811828 Author: john-ezra <[email protected]> Date: Fri Sep 17 23:51:09 2021 -0700 [Keymap] Major Updates to Personal Kyria Keymap (#14485) * added john ezra keymap with updates * changed tapping term commit f93597d66b0698cbea87b24aad79f60e5a9db6ad Author: Takeshi ISHII <[email protected]> Date: Sat Sep 18 11:51:04 2021 +0900 fix link error for helix/rev3_5rows:five_rows (#14466) This is a tentative quick fix. I was adding the same functions for both #14426 and #14427 and they were in conflict. commit 7c09b2667b49839d6c1a27133751d43642149a84 Author: James Young <[email protected]> Date: Fri Sep 17 20:48:14 2021 +0000 Nix Studio OXALYS80 Refactor (#14473) * update grid alignment of keycodes * update key assignments on via keymap A seemingly-misplaced key assignment on Layers 1 through 3 of the via keymap led to keys being off by one in comparison to the default keymap. * switch Backslash and Backspace on via keymap base layer Matches the via keymap's key mapping to that of the default keymap. * use QMK 3-character notation in oxalys80.h * add matrix diagram; remove Planck reference * add LAYOUT_tkl_ansi and LAYOUT_tkl_ansi_wkl layout macros * add LAYOUT_tkl_ansi_tsangan macro * add ISO layouts Add LAYOUT_tkl_iso, LAYOUT_tkl_iso_tsangan, and LAYOUT_tkl_iso_wkl macros. * enable Community Layouts support * tidy up rules.mk * readme tidy-up commit 0c1341daa80b79ccbef8a9e7f895552ff57456e9 Author: Drashna Jaelre <[email protected]> Date: Fri Sep 17 13:01:06 2021 -0700 [Keyboard] Move Planck EZ off 'Proton C' board (#14479) commit 40578621a76b43481116fd73b10b8cdec3d3a7ef Author: Drashna Jaelre <[email protected]> Date: Fri Sep 17 13:00:42 2021 -0700 [Keyboard] Move Moonlander off 'Proton C' board (#14478) commit c9b91443e1c05900ffb007e3321446fcdb219bd2 Author: X-Bows Tech <[email protected]> Date: Sat Sep 18 00:48:11 2021 +0800 Update rules.mk for xbows keyboard (#14477) * Update rules.mk * Update rules.mk * Update rules.mk commit 3496513865b0b1ac1b4c3771c64581e626428c4d Author: Matt <[email protected]> Date: Fri Sep 17 00:38:11 2021 -0400 [Keymap] Adding personal keymap (#14326) Co-authored-by: Ryan <[email protected]> Co-authored-by: Drashna Jaelre <[email protected]> commit b1605f2ad98c762f1d04fb75f736e2687905aca1 Author: Andy Yong <[email protected]> Date: Thu Sep 16 23:19:58 2021 -0400 [Keyboard] Add Sauce Mild Keyboard (#14287) Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: Ryan <[email protected]> commit 87665f404b48d5b60744c0774e69770a63686d3b Author: r-pufky <[email protected]> Date: Thu Sep 16 20:15:01 2021 -0700 [Keymap] Add gaming toggle layer & layer colors to r-pufky keymap. (#14251) commit c6b87be8c7d04f6a88ab7f3e354475d20dbf50d9 Author: Álvaro A. Volpato <[email protected]> Date: Thu Sep 16 17:42:26 2021 -0300 Mode 65S: Tap code and extra keys for media keys (#14471) commit 85a0c494ffde3dfa555bbe32bb083eec85b9ca72 Author: Takeshi ISHII <[email protected]> Date: Thu Sep 16 18:47:47 2021 +0900 [Keymap] Update Helix:five_rows OLED code (#14427) * Stop using snprintf() in keymaps/five_rows/oled_display.c. The binary size becomes 1350 bytes smaller. make HELIX=verbose,core-oled helix/rev2/sc:five_rows (104 bytes over) -> (95%, 1256 bytes free) make helix/rev3_5rows:five_rows (528 bytes over) -> (97%, 830 bytes free) * add matrix scan rate display to OLED for keymaps/five_rows * add matrix_output_unselect_delay.c to helix keymaps/five_rows * add GPLv2 header * apply review comment commit 13b93c212da202d210ba28657f1b1c3e06d56655 Author: Takeshi ISHII <[email protected]> Date: Thu Sep 16 18:46:51 2021 +0900 [Keyboard] Increase the way to add oled code for helix/rev3. (#14426) * move rev3_Xrows/oled_display.c to rev3_Xrows/keymaps/default/oled_display.c * add dummy rev3_Xrows/oled_display.c * Add default minimum oled_task_user() to helix/rev3_Xrows/rev3_Xrows.c * remove unnecessary comment in rev3_Xrows/keymaps/default/oled_display.c * copy rev3_Xrows/keymaps/default/oled_display.c to rev3_Xrows/keymaps/via/oled_display.c commit d140e41c93dcf0a429392310858ac905447324ac Author: Jos Boersema <[email protected]> Date: Thu Sep 16 07:27:44 2021 +0200 Adds optional hebrew layout (Unicode) (#14156) commit b5cc2bdc34d9091e7b31fcb9676e0d37b0282aad Author: Vino Rodrigues <[email protected]> Date: Thu Sep 16 13:28:40 2021 +1000 [Keyboard] Add the Idobao ID96 keyboard (#14371) Co-authored-by: Joel Challis <[email protected]> Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: Ryan <[email protected]> commit ae821ce4b77f873f5122747ee48c02778637bac6 Author: Felix Jen <[email protected]> Date: Wed Sep 15 19:25:30 2021 -0700 [Keyboard] Add FJLabs TF60 Variants and TF65 Variant (#14392) Co-authored-by: Ryan <[email protected]> commit 40c58b1734a074106610e4e0006054b4ccef4f9a Author: Felix Jen <[email protected]> Date: Wed Sep 15 19:25:03 2021 -0700 [Keyboard] Add Absolute Designs AD65 Keyboard (#14391) Co-authored-by: Ryan <[email protected]> commit 303e063b71bba2b049f160a8bc50f33ac9538d8f Author: yulei <[email protected]> Date: Thu Sep 16 01:20:20 2021 +0800 [Keyboard] add Matrix Me (#14331) Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: Ryan <[email protected]> commit 4b7503097c28f33686073e37061bd178b8359600 Author: Felix Jen <[email protected]> Date: Wed Sep 15 10:18:47 2021 -0700 [Keyboard] Replaced Maker Keyboards & FJLabs Legacy Code (#14393) commit 0097886db62f25eb495cf8941867f89d397d9251 Author: Albert Y <[email protected]> Date: Thu Sep 16 01:16:32 2021 +0800 [Keyboard] Add `NO_LED` positions to match key matrix. (#14417) Co-authored-by: filterpaper <filterpaper@localhost> commit 9503d8bd039d797e94169f851c8ffcd78de5a95c Author: IFo Hancroft <[email protected]> Date: Wed Sep 15 20:15:42 2021 +0300 [Keymap] A slight improvement to my own ErgoDox keymap (#14425) commit 0f3343aa9396242ec31c0da8eec82f475bdff93b Author: peott-fr <[email protected]> Date: Wed Sep 15 10:14:57 2021 -0700 [Keymap] Trying again with Prime-e update! (#14429) commit 6930eed964f18a9021fc6c6781e6fa3066290ed9 Author: X-Bows Tech <[email protected]> Date: Thu Sep 16 01:14:05 2021 +0800 [Keyboard] Update lighting effects for xbows keyboard (#14432) commit 12a8e59e9c0fc803b33e63a0901aa9fdba270c53 Author: Dasky <[email protected]> Date: Wed Sep 15 18:11:25 2021 +0100 [Docs] add sync options heading, update led indicators (#14441) Co-authored-by: Ryan <[email protected]> commit 169d5bd21d9381843914b4c23cbca1b447e905c6 Author: Drashna Jaelre <[email protected]> Date: Wed Sep 15 10:07:08 2021 -0700 [Bug] Fix IS31fl3741 driver to accept 1 or 2 addresses (#14451) Co-authored-by: Joel Challis <[email protected]> commit 7e36a8138379cab2d27a9db407850b67e46e0d0b Author: Drashna Jaelre <[email protected]> Date: Wed Sep 15 01:31:25 2021 -0700 [Keyboard] Fix Boop65 rgb compile issues (#14444) commit a2d43ca024d8e840c882cc72e80e9eb6b70384f1 Author: Dan Nixon <[email protected]> Date: Wed Sep 15 07:56:12 2021 +0100 [Keyboard] Add Aya keyboard (#14378) Co-authored-by: Ryan <[email protected]> commit c2f2f9bfd3f5c927496a80e7074fa7c54a2c1619 Author: moyi4681 <[email protected]> Date: Wed Sep 15 14:00:48 2021 +0800 [Keyboard] add kbd75 hotswap keyboard (#14283) Co-authored-by: Joel Challis <[email protected]> Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: Ryan <[email protected]> commit 07a4e3b1762fb0800c4cb89bf646f6c82c8a95b7 Author: moyi4681 <[email protected]> Date: Wed Sep 15 13:20:34 2021 +0800 [Keyboard] add boop65 rgb keyboard (#14166) Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: Ryan <[email protected]> commit 344a73fddd4729a2aa8346437273050971be6ae7 Author: Wolf Van Herreweghe <[email protected]> Date: Wed Sep 15 06:20:07 2021 +0100 [Keyboard] Add KeyBee65 (#14163) Co-authored-by: Ryan <[email protected]> Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: Wolf Van Herreweghe <[email protected]> commit 34352890522309e28b1788f72feab01e268eff34 Author: bomb <[email protected]> Date: Wed Sep 15 13:09:49 2021 +0800 [Keyboard] Add Mach80 for Melgeek (#14076) Co-authored-by: Ryan <[email protected]> Co-authored-by: Drashna Jaelre <[email protected]> commit fcebd17267787daba54ec5f26b653ef0fa3f3691 Author: jmcwilliams403 <[email protected]> Date: Wed Sep 15 00:44:41 2021 -0400 [Keyboard] added 64_ansi_split_bs layout (#13776) commit 830fb5fd05e2f7bb528d8fda5ffccf140529ab37 Author: ぺらねこ <[email protected]> Date: Wed Sep 15 13:21:31 2021 +0900 [Keyboard] Update peranekofactory/tone/rev2/rev2.h (#13610) I changed the description that was mistakenly described as the same wiring as Rev1 to the correct description. commit 657323a2069ed821907a5ab1435b11c8438e3d78 Author: vsrivastava <[email protected]> Date: Tue Sep 14 21:12:37 2021 -0700 [Docs] fixed incorrect amount of steps for oled usage (#13519) changed line 21 from saying "three steps" to "two steps" as there are only two steps Co-authored-by: feynmantf <[email protected]> commit 00c60c9410abae3315e70fe9a9c9febaf9a8e7a1 Author: drhigsby <[email protected]> Date: Tue Sep 14 20:55:09 2021 -0700 [Keyboard] Dubba175 Default Keymap Update (#13486) Co-authored-by: Dr…

@germ

* Moved gergoplex to seperate PR * vendor + cformat * Update keyboards/gboards/k/gergoplex/matrix.c Co-Authored-By: Drashna Jaelre <[email protected]> * lifiting keyboards up * Update readme.md * Update keyboards/gboards/gergoplex/config.h Co-authored-by: Drashna Jaelre <[email protected]> * remove English dicts * cformatted * Prettify keymap * Remove via keymaps Via doesn't support chords/combos, and this makes the keymap on such a small keyboard quite uncomfortable and incomplete. * Address QMK pull code review notes * Cleanup (tabs, excessive comments) * Fix keymap typos * Use enum to define layers * Multiple changes - got rid of LAYOUT_kc in favour of LAYOUT_split_3x5_3 - fixed matrix custom C code to build with updated external dependencies (gcc) - fixed used combo docs keyboards/gboards/gergoplex/matrix.c:189:9: error: implicit declaration of function 'phex' [-Werror=implicit-function-declaration] phex(row); ^~~~ keyboards/gboards/gergoplex/matrix.c:191:9: error: implicit declaration of function 'pbin_reverse16'; did you mean 'print_bin_reverse16'? [-Werror=implicit-function-declaration] pbin_reverse16(matrix_get_row(row)); * Remove apparently redundant macros * Replace direct pin control with IO functions * config mouse enable and combo delay fix The default delay is 200: #define COMBO_TERM 200 how long for the Combo keys to be detected. Defaults to TAPPING_TERM if not defined. tmk_core/common/action_tapping.h|22| 13:# define TAPPING_TERM 200 * Remove redundant defines * Unambiguously refer to the Special layer * Fix formatting * gboards/gergoplex set IGNORE_MOD_TAP_INTERRUPT This solves my issue was with KC_CTL_A working correctly and it was set in @germ's repo https://github.com/germ/qmk_firmware/blob/39c86e080dc04b68ee08387dcb5144c88cb44855/keyboards/gboards/k/gergoplex/config.h#L49 https://beta.docs.qmk.fm/using-qmk/software-features/tap_hold#ignore-mod-tap-interrupt * Name change See commit 5813685 * Wording change * Update keyboards/gboards/gergoplex/keymaps/default/keymap.c Co-authored-by: Drashna Jaelre <[email protected]> * Add copyright headers * Fix debounce type | avr-gcc: error: .build/obj_gboards_gergoplex_default/quantum/debounce/eager_pr.o: No such file or directory * Implement colemak-dhm keymap Co-authored-by: Germ <[email protected]> Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: Brian Tannous <[email protected]>

@germ

* Moved gergoplex to seperate PR * vendor + cformat * Update keyboards/gboards/k/gergoplex/matrix.c Co-Authored-By: Drashna Jaelre <[email protected]> * lifiting keyboards up * Update readme.md * Update keyboards/gboards/gergoplex/config.h Co-authored-by: Drashna Jaelre <[email protected]> * remove English dicts * cformatted * Prettify keymap * Remove via keymaps Via doesn't support chords/combos, and this makes the keymap on such a small keyboard quite uncomfortable and incomplete. * Address QMK pull code review notes * Cleanup (tabs, excessive comments) * Fix keymap typos * Use enum to define layers * Multiple changes - got rid of LAYOUT_kc in favour of LAYOUT_split_3x5_3 - fixed matrix custom C code to build with updated external dependencies (gcc) - fixed used combo docs keyboards/gboards/gergoplex/matrix.c:189:9: error: implicit declaration of function 'phex' [-Werror=implicit-function-declaration] phex(row); ^~~~ keyboards/gboards/gergoplex/matrix.c:191:9: error: implicit declaration of function 'pbin_reverse16'; did you mean 'print_bin_reverse16'? [-Werror=implicit-function-declaration] pbin_reverse16(matrix_get_row(row)); * Remove apparently redundant macros * Replace direct pin control with IO functions * config mouse enable and combo delay fix The default delay is 200: #define COMBO_TERM 200 how long for the Combo keys to be detected. Defaults to TAPPING_TERM if not defined. tmk_core/common/action_tapping.h|22| 13:# define TAPPING_TERM 200 * Remove redundant defines * Unambiguously refer to the Special layer * Fix formatting * gboards/gergoplex set IGNORE_MOD_TAP_INTERRUPT This solves my issue was with KC_CTL_A working correctly and it was set in @germ's repo https://github.com/germ/qmk_firmware/blob/39c86e080dc04b68ee08387dcb5144c88cb44855/keyboards/gboards/k/gergoplex/config.h#L49 https://beta.docs.qmk.fm/using-qmk/software-features/tap_hold#ignore-mod-tap-interrupt * Name change See commit 5813685 * Wording change * Update keyboards/gboards/gergoplex/keymaps/default/keymap.c Co-authored-by: Drashna Jaelre <[email protected]> * Add copyright headers * Fix debounce type | avr-gcc: error: .build/obj_gboards_gergoplex_default/quantum/debounce/eager_pr.o: No such file or directory * Implement colemak-dhm keymap Co-authored-by: Germ <[email protected]> Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: Brian Tannous <[email protected]>

github-actions bot added keyboard keymap labels May 28, 2021

pirj mentioned this pull request May 28, 2021

Add gBoards GergoPlex firmware #10406

Closed

14 tasks

pirj changed the title ~~gBoards Gergoplex~~ gBoards GergoPlex May 28, 2021

bttnns reviewed May 28, 2021

View reviewed changes

keyboards/gboards/gergoplex/keymaps/default/rules.mk Outdated Show resolved Hide resolved

bttnns mentioned this pull request May 30, 2021

gboards/Gergoplex sync master, add colemak DHm pirj/qmk_firmware#3

Closed

drashna requested changes May 30, 2021

View reviewed changes

stale bot added awaiting changes and removed awaiting changes labels Jul 16, 2021

pirj force-pushed the prettify-gergoplex branch from 64875d8 to ff1299e Compare July 30, 2021 15:39

pirj requested a review from drashna July 30, 2021 15:39

caksoylar reviewed Aug 13, 2021

View reviewed changes

keyboards/gboards/gergoplex/rules.mk Outdated Show resolved Hide resolved

pirj force-pushed the prettify-gergoplex branch from ff1299e to c868748 Compare August 14, 2021 21:25

github-actions bot added CI core documentation labels Aug 14, 2021

pirj force-pushed the prettify-gergoplex branch from c868748 to 883b484 Compare August 14, 2021 21:33

github-actions bot removed documentation CI core via Adds via keymap and/or updates keyboard for via support translation labels Aug 14, 2021

This comment has been minimized.

Sign in to view

Fix debounce type

bd8b01c

| avr-gcc: error: .build/obj_gboards_gergoplex_default/quantum/debounce/eager_pr.o: No such file or directory

pirj force-pushed the prettify-gergoplex branch from 883b484 to d3e186b Compare August 15, 2021 15:38

Implement colemak-dhm keymap

6dc76f4

pirj force-pushed the prettify-gergoplex branch from d3e186b to 6dc76f4 Compare August 15, 2021 15:59

drashna approved these changes Sep 11, 2021

View reviewed changes

drashna requested a review from a team September 11, 2021 03:09

bttnns approved these changes Sep 19, 2021

View reviewed changes

drashna merged commit 8d32ddd into qmk:master Sep 21, 2021

fauxpark mentioned this pull request Mar 28, 2022

gboards/gergoplex: move COMBO_ENABLE to keymap level #16667

Merged

14 tasks

pirj deleted the prettify-gergoplex branch November 2, 2024 18:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

gBoards GergoPlex #13027

gBoards GergoPlex #13027

pirj commented May 28, 2021 •

edited

Loading

bttnns commented May 28, 2021 •

edited

Loading

bttnns commented May 28, 2021 •

edited

Loading

bttnns commented May 28, 2021 •

edited

Loading

pirj commented May 28, 2021

bttnns commented May 28, 2021 •

edited

Loading

pirj commented May 28, 2021

bttnns commented May 28, 2021

stale bot commented Jul 16, 2021

Telltak commented Jul 17, 2021

ghost commented Jul 25, 2021 •

edited by ghost

Loading

caksoylar commented Jul 25, 2021

drashna commented Jul 30, 2021

pirj commented Jul 30, 2021

pirj commented Jul 30, 2021

pirj commented Aug 14, 2021

This comment has been minimized.

pirj commented Aug 15, 2021

Telltak commented Sep 9, 2021

bttnns commented Sep 11, 2021

bttnns commented Sep 17, 2021 •

edited

Loading

pirj commented Sep 21, 2021

gBoards GergoPlex #13027

gBoards GergoPlex #13027

Conversation

pirj commented May 28, 2021 • edited Loading

Description

Not done

Types of Changes

Issues Fixed or Closed by This PR

Checklist

bttnns commented May 28, 2021 • edited Loading

bttnns commented May 28, 2021 • edited Loading

bttnns commented May 28, 2021 • edited Loading

pirj commented May 28, 2021

bttnns commented May 28, 2021 • edited Loading

pirj commented May 28, 2021

bttnns commented May 28, 2021

stale bot commented Jul 16, 2021

Telltak commented Jul 17, 2021

ghost commented Jul 25, 2021 • edited by ghost Loading

caksoylar commented Jul 25, 2021

drashna commented Jul 30, 2021

pirj commented Jul 30, 2021

pirj commented Jul 30, 2021

pirj commented Aug 14, 2021

This comment has been minimized.

pirj commented Aug 15, 2021

Telltak commented Sep 9, 2021

bttnns commented Sep 11, 2021

bttnns commented Sep 17, 2021 • edited Loading

pirj commented Sep 21, 2021

pirj commented May 28, 2021 •

edited

Loading

bttnns commented May 28, 2021 •

edited

Loading

bttnns commented May 28, 2021 •

edited

Loading

bttnns commented May 28, 2021 •

edited

Loading

bttnns commented May 28, 2021 •

edited

Loading

ghost commented Jul 25, 2021 •

edited by ghost

Loading

bttnns commented Sep 17, 2021 •

edited

Loading