Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Because my keyboard has both an RGB LED matrix and an LCD, I need to enable both visualizer and rgb_matrix. They both contain a
point_t
with different definitions and so wouldn't compile. ugfx is vendored, so I made my small change in the rgb_matrix library.A quick grep indicates that point_t wasn't used anywhere outside rgb_matrix*, so this shouldn't be a breaking change.
I didn't change the LED matrix, as I'm not using that, but I could add a commit for that as well.
Types of Changes
Issues Fixed or Closed by This PR
Checklist