Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

point_t disambiguation #12944

Closed
wants to merge 1 commit into from
Closed

point_t disambiguation #12944

wants to merge 1 commit into from

Conversation

stillinbeta
Copy link

Description

Because my keyboard has both an RGB LED matrix and an LCD, I need to enable both visualizer and rgb_matrix. They both contain a point_t with different definitions and so wouldn't compile. ugfx is vendored, so I made my small change in the rgb_matrix library.

A quick grep indicates that point_t wasn't used anywhere outside rgb_matrix*, so this shouldn't be a breaking change.

I didn't change the LED matrix, as I'm not using that, but I could add a commit for that as well.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label May 19, 2021
@fauxpark
Copy link
Member

This has already been done in #12864.

@fauxpark fauxpark closed this May 19, 2021
@stillinbeta
Copy link
Author

my branch needed a rebase, my bad!

@fauxpark
Copy link
Member

I should also note that the Visualizer and uGFX will be going away soon-ish, as the uGFX license is incompatible with QMK's, the upshot of which is that any keyboard using the uGFX code cannot be built using the Configurator (eg. Ergodox Infinity and Whitefox). So I would not recommend getting too attached to it.

The successor to the Visualizer will likely be Quantum Painter: #10174

@stillinbeta stillinbeta deleted the rgb_point branch May 19, 2021 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants