Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a new keyboard called Rosa #12884

Merged
merged 8 commits into from
May 16, 2021
Merged

Add a new keyboard called Rosa #12884

merged 8 commits into from
May 16, 2021

Conversation

illvsixn
Copy link

Description

Adding a new keyboard.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • N/A

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

fauxpark
fauxpark requested changes May 12, 2021
View reviewed changes
keyboards/illusion/rosa/README.md Outdated Show resolved Hide resolved
keyboards/illusion/rosa/rosa.c Outdated Show resolved Hide resolved
keyboards/illusion/rosa/rules.mk Outdated Show resolved Hide resolved
@fauxpark fauxpark requested a review from a team May 13, 2021 01:25
@illvsixn

This comment has been minimized.

Sign in to view
@github-actions github-actions bot added the via Adds via keymap and/or updates keyboard for via support label May 15, 2021
@drashna
Copy link
Member

drashna commented May 16, 2021

Thanks!

@drashna drashna merged commit 60cf7ae into qmk:master May 16, 2021
@illvsixn illvsixn mentioned this pull request May 16, 2021
Merged
6 tasks
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Jul 11, 2021
@illvsixn @fauxpark @HokieGeek
[Keyboard] Add Rosa (qmk#12884)
b5d5f0a 
Co-authored-by: Ryan <[email protected]>
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@illvsixn @fauxpark @nhongooi
[Keyboard] Add Rosa (qmk#12884)
981f493 
Co-authored-by: Ryan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@illvsixn @drashna @fauxpark