Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Potato65 Hotswap keyboard #12874

Merged
merged 13 commits into from
May 15, 2021
Merged

Add Potato65 Hotswap keyboard #12874

merged 13 commits into from
May 15, 2021

Conversation

Aeonstrife
Copy link
Contributor

Description

Added support for Potato65 Hotswap keyboard.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • Adds support for the Potato65 hotswap keyboard.

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels May 12, 2021
@Aeonstrife Aeonstrife changed the title Make initial set of files Add Potato65 Hotswap keyboard May 12, 2021
Aeonstrife added 2 commits May 12, 2021 06:25
@Aeonstrife
Update pootato65hs.h
bb45497 
fixed pinmap
@Aeonstrife
Update config.h
9c9a0d9 
Updated vendor id
@Aeonstrife Aeonstrife mentioned this pull request May 12, 2021
Merged
6 tasks
Aeonstrife added 3 commits May 12, 2021 07:58
@Aeonstrife
Update keymap.c
a38c08f 
Changed layout from LAYOUT_65_ansi to LAYOUT_65_ansi_blocker
@Aeonstrife
Update rules.mk
9b6cdd6 
enabled nkeyrollover and changed layout
@Aeonstrife
Update potato65hs.h
4a8a247 
Changed layout from LAYOUT_65_ansi to LAYOUT_65_ansi_blocker
fauxpark
fauxpark requested changes May 13, 2021
View reviewed changes
keyboards/buildakb/potato65hs/info.json Outdated Show resolved Hide resolved
keyboards/buildakb/potato65hs/readme.md Outdated Show resolved Hide resolved
@Aeonstrife
Update info.json and readme.md
310f987 
fixed layout and image
@Aeonstrife Aeonstrife requested a review from fauxpark May 13, 2021 01:06
fauxpark
fauxpark requested changes May 13, 2021
View reviewed changes
keyboards/buildakb/potato65hs/config.h Outdated Show resolved Hide resolved
@fauxpark fauxpark requested a review from a team May 13, 2021 01:27
drashna
drashna requested changes May 13, 2021
View reviewed changes
keyboards/buildakb/potato65hs/config.h Outdated Show resolved Hide resolved
keyboards/buildakb/potato65hs/config.h Outdated Show resolved Hide resolved
@Aeonstrife Aeonstrife requested a review from drashna May 13, 2021 19:55
@Aeonstrife
Update readme.md
cc2261c 
added instructions for bootloader mode
@Aeonstrife Aeonstrife requested a review from drashna May 14, 2021 13:35
@Aeonstrife
Update config.h
0a03df2 
format license comment
@drashna
Copy link
Member

drashna commented May 15, 2021

Thanks!

@drashna drashna merged commit cc77710 into qmk:master May 15, 2021
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Jul 11, 2021
@Aeonstrife @fauxpark
@drashna @HokieGeek
[Keyboard] Add Potato65 Hotswap keyboard (qmk#12874)
177eb12 
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@Aeonstrife @fauxpark
@drashna @nhongooi
[Keyboard] Add Potato65 Hotswap keyboard (qmk#12874)
6d2de50 
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Aeonstrife @drashna @fauxpark