Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add config.h and rules.mk support for data driven keymaps #12859

Merged
merged 5 commits into from
Aug 18, 2021
Merged

Add config.h and rules.mk support for data driven keymaps #12859

merged 5 commits into from
Aug 18, 2021

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented May 10, 2021

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added cli qmk cli command core keymap python via Adds via keymap and/or updates keyboard for via support labels May 10, 2021
@firetech
Copy link
Contributor

Since this seems to rename the keymap.c file created when building from json, I think this would also require at least a minor change to the last line of build_layout.mk?

@stale
Copy link

stale bot commented Jun 26, 2021

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@stale stale bot removed the awaiting changes label Jun 28, 2021
@drashna drashna requested a review from a team July 3, 2021 07:19
@zvecr zvecr added the breaking_change Changes that need to wait for a version increment label Jul 29, 2021
@zvecr zvecr force-pushed the feature/keymap_json_config_rules branch from 00c5dc5 to 66bf4fc Compare August 16, 2021 23:14
@zvecr zvecr changed the base branch from master to develop August 16, 2021 23:16
@zvecr zvecr marked this pull request as ready for review August 16, 2021 23:58
@tzarc tzarc requested a review from a team August 17, 2021 18:53
@zvecr zvecr removed the breaking_change Changes that need to wait for a version increment label Aug 17, 2021
@zvecr zvecr merged commit 2e734fb into qmk:develop Aug 18, 2021
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@zvecr @nhongooi
Add config.h and rules.mk support for data driven keymaps (qmk#12859)
afa50ff 
* Add config.h and rules.mk support for data driven keymaps

* tidy up after rebase

* Rename key as it can contain more than just keyboard overrides

* tidy up after rebase

* Add validation
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@zvecr
Add config.h and rules.mk support for data driven keymaps (qmk#12859)
36c19cb 
* Add config.h and rules.mk support for data driven keymaps

* tidy up after rebase

* Rename key as it can contain more than just keyboard overrides

* tidy up after rebase

* Add validation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
cli qmk cli command core keymap python via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zvecr @firetech @tzarc