Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Update Japanese newbs_building_firmware_configurator.md #12836

Merged
merged 1 commit into from
Jun 7, 2021
Merged

[Docs] Update Japanese newbs_building_firmware_configurator.md #12836

merged 1 commit into from
Jun 7, 2021

Conversation

shelaf
Copy link
Contributor

@shelaf shelaf commented May 9, 2021

Description

Update Japanese document.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@mtei
Copy link
Contributor

mtei commented May 9, 2021

@umi-umi @s-show @hsgw @satt99 @takashiski @yoshihara よかったらレビューお願いします。

@mtei mtei requested a review from a team June 6, 2021 08:06
@mtei
Copy link
Contributor

mtei commented Jun 6, 2021

I think this is ready to merge.

@mtei mtei merged commit b52b8f1 into qmk:master Jun 7, 2021
@mtei
Copy link
Contributor

mtei commented Jun 7, 2021

Thanks!

@shelaf shelaf deleted the ja_newbs_building_firmware_configurator branch June 7, 2021 22:02
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Jul 11, 2021
@shelaf @HokieGeek
Update Japanese newbs_building_firmware_configurator.md document. (qm…
d1563ef 
…k#12836)
wox pushed a commit to wox/qmk_firmware that referenced this pull request Aug 14, 2021
@shelaf @wox
Update Japanese newbs_building_firmware_configurator.md document. (qm…
0d32c0b 
…k#12836)
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@shelaf @nhongooi
Update Japanese newbs_building_firmware_configurator.md document. (qm…
e5d2cd4 
…k#12836)
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@shelaf
Update Japanese newbs_building_firmware_configurator.md document. (qm…
2e73836 
…k#12836)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umi-umi umi-umi umi-umi approved these changes

@mtei mtei mtei approved these changes

Assignees
No one assigned
Labels
documentation translation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shelaf @mtei @umi-umi