Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix up bad keycode in #12405 #12722

Merged
merged 1 commit into from
Apr 28, 2021
Merged

Fix up bad keycode in #12405 #12722

merged 1 commit into from
Apr 28, 2021

Conversation

tzarc
Copy link
Member

@tzarc tzarc commented Apr 28, 2021

Description

Build failures. @matthewdias confirm fix please?

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc tzarc requested a review from a team April 28, 2021 04:55
matthewdias
matthewdias approved these changes Apr 28, 2021
View reviewed changes
Copy link
Contributor

@matthewdias matthewdias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, thanks for fixing

@zvecr zvecr merged commit 54e8dd0 into qmk:master Apr 28, 2021
rizo pushed a commit to rizo/qmk_firmware that referenced this pull request May 10, 2021
@tzarc @rizo
Fix up bad keycode in qmk#12405. (qmk#12722)
c5d16b3
toddyamakawa pushed a commit to toddyamakawa/qmk_firmware that referenced this pull request May 19, 2021
@tzarc @toddyamakawa
Fix up bad keycode in qmk#12405. (qmk#12722)
ef69147
@tzarc tzarc deleted the fixup-12405 branch May 23, 2021 23:14
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Jul 11, 2021
@tzarc @HokieGeek
Fix up bad keycode in qmk#12405. (qmk#12722)
9057d78
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@matthewdias matthewdias matthewdias approved these changes

Assignees
No one assigned
Labels
bug keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tzarc @matthewdias @zvecr